-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable failing TLS 1.0/1.1 tests #3130
Conversation
Tests were failing in main branch - CI environment only supports TLS 1.2
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/ConnectionTestParametersData.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/ConnectionTestParametersData.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in-file.
Thanks @paulmedynski, I've addressed them. Would you mind triggering the pipeline again please? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3130 +/- ##
==========================================
- Coverage 72.72% 66.10% -6.62%
==========================================
Files 283 277 -6
Lines 58996 58687 -309
==========================================
- Hits 42905 38797 -4108
- Misses 16091 19890 +3799
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@edwardneal I'm not 100% sure about these failures, but can you merge/rebase from main and we can try again? @David-Engel made some changes that should fix running CI pipelines from forks |
I've just done that. The pipeline hasn't run automatically though, so needs another trigger. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Ok, it all looks good to me 🚢 |
Rolls up change from original connection test matrix #3127. Corrects #3126, removing its associated test.
CI is currently failing on main branch - it no longer supports TLS 1.0/1.1, so the tests which require TLS 1.2 are failing. This PR removes them.
Does not require porting to release/6.0.
cc @benrr101