Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing TLS 1.0/1.1 tests #3130

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

edwardneal
Copy link
Contributor

Rolls up change from original connection test matrix #3127. Corrects #3126, removing its associated test.
CI is currently failing on main branch - it no longer supports TLS 1.0/1.1, so the tests which require TLS 1.2 are failing. This PR removes them.

Does not require porting to release/6.0.

cc @benrr101

Tests were failing in main branch - CI environment only supports TLS 1.2
@benrr101
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101 benrr101 requested a review from a team January 22, 2025 23:32
Copy link

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in-file.

@edwardneal
Copy link
Contributor Author

Thanks @paulmedynski, I've addressed them. Would you mind triggering the pipeline again please?

@paulmedynski
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base (ebfbebb) to head (4782c74).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ebfbebb) and HEAD (4782c74). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (ebfbebb) HEAD (4782c74)
addons 5 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
- Coverage   72.72%   66.10%   -6.62%     
==========================================
  Files         283      277       -6     
  Lines       58996    58687     -309     
==========================================
- Hits        42905    38797    -4108     
- Misses      16091    19890    +3799     
Flag Coverage Δ
addons ?
netcore 69.19% <ø> (-6.31%) ⬇️
netfx 64.86% <ø> (-6.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101
Copy link
Contributor

@edwardneal I'm not 100% sure about these failures, but can you merge/rebase from main and we can try again? @David-Engel made some changes that should fix running CI pipelines from forks

@edwardneal
Copy link
Contributor Author

I've just done that. The pipeline hasn't run automatically though, so needs another trigger.

@cheenamalhotra
Copy link
Member

/azp run

@cheenamalhotra cheenamalhotra added this to the 7.0-preview1 milestone Jan 26, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101
Copy link
Contributor

Ok, it all looks good to me 🚢

@benrr101 benrr101 merged commit 82edd8b into dotnet:main Jan 28, 2025
123 checks passed
@edwardneal edwardneal deleted the correct-pr-3126 branch January 28, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants