Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review username and password defaults for all container and azure resources and make them consistent. #2403

Closed
davidfowl opened this issue Feb 25, 2024 · 1 comment · Fixed by #3023
Closed

Review username and password defaults for all container and azure resources and make them consistent. #2403

davidfowl opened this issue Feb 25, 2024 · 1 comment · Fixed by #3023
Assignees
@eerhardt
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication security 🔐
Milestone
preview 5 (Apr)

Comments

@davidfowl
Copy link
Member

davidfowl commented Feb 25, 2024 •
edited
Loading

We should support:

  1. Picking a username and password (using Parameter resources)
  2. Defaulting a username and randomly generating a password
  3. Picking a username and generating a password

Related #2389
@davidfowl davidfowl added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 25, 2024
@davidfowl davidfowl added this to the preview 5 (Apr) milestone Feb 25, 2024
@davidfowl davidfowl changed the title Review username and password defaults for all container resources and make them consistent Review username and password defaults for all container and azure resources and make them consistent. Feb 26, 2024
@davidfowl
Copy link
Member Author

@eerhardt giving this to you

@eerhardt eerhardt mentioned this issue Feb 28, 2024
Closed
@eerhardt eerhardt mentioned this issue Mar 13, 2024
Merged
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 14, 2024
@eerhardt
Support Postgres user name and password from Parameter
c2ace64 
Contributes to dotnet#2403
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 14, 2024
@eerhardt
Support Postgres user name and password from Parameter
45966ff 
Contributes to dotnet#2403
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 14, 2024
@eerhardt
Support Postgres user name and password from Parameter
bd62607 
Contributes to dotnet#2403
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 15, 2024
@eerhardt
Support Postgres user name and password from Parameter
4f9a002 
Contributes to dotnet#2403
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 18, 2024
@eerhardt
Support Postgres user name and password from Parameter
b7b5742 
Contributes to dotnet#2403
eerhardt added a commit that referenced this issue Mar 18, 2024
@eerhardt
Support Postgres user name and password from Parameter (#2868)
914760c 
Contributes to #2403
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 19, 2024
@eerhardt
Make username and password defaults consistent
b4e2b63 
* Support RabbitMQ username and password from Parameter
* Support MySql password from Parameter
* Support Oracle password from Parameter
* Support SQL Server password from Parameter

Fix dotnet#2403
@eerhardt eerhardt mentioned this issue Mar 19, 2024
Merged
eerhardt added a commit to eerhardt/aspire that referenced this issue Mar 20, 2024
@eerhardt
Make username and password defaults consistent
08a4941 
* Support RabbitMQ username and password from Parameter
* Support MySql password from Parameter
* Support Oracle password from Parameter
* Support SQL Server password from Parameter

Fix dotnet#2403
eerhardt added a commit that referenced this issue Mar 21, 2024
@eerhardt
Make username and password defaults consistent (#3023)
717e03a 
* Make username and password defaults consistent

* Support RabbitMQ username and password from Parameter
* Support MySql password from Parameter
* Support Oracle password from Parameter
* Support SQL Server password from Parameter

Fix #2403

* Don't add the password input if a parameter has been specified.

* Regenerate the playground aspire-manifest.json files.
@davidfowl davidfowl mentioned this issue Mar 23, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication security 🔐
Projects
None yet
Milestone
preview 5 (Apr)
Development

Successfully merging a pull request may close this issue.

Make username and password defaults consistent eerhardt/aspire
3 participants
@davidfowl @danmoseley @eerhardt