Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Postgres user name and password from Parameter #2868

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Mar 13, 2024

Contributes to #2403

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 13, 2024
@eerhardt eerhardt force-pushed the PasswordAPIs branch 2 times, most recently from c2ace64 to 45966ff Compare March 14, 2024 19:32
@eerhardt eerhardt changed the title Support Postgres password from Parameter Support Postgres user name and password from Parameter Mar 14, 2024
@eerhardt eerhardt marked this pull request as ready for review March 14, 2024 19:47
@eerhardt
Copy link
Member Author

Once the pattern is established here, I can do the other resources to follow this same pattern. The ones that support password today:

  • MySql
  • Oracle
  • Postgres
  • RabbitMQ
  • SqlServer

Of those, the only containers that support customizing the user name is:

  • Postgres
  • RabbitMQ

The other 3 (MySql, Oracle, SqlServer) don't have an ENV VAR to change the user name as far as I can tell from reading the docs.

The other resources that don't support password today (and I don't plan on making them support a password as part of #2403):

  • Kafka
  • MongoDB
  • Nats
  • Redis
  • Seq (this one does have an API key, but it doesn't put it in the connection string)

@eerhardt eerhardt enabled auto-merge (squash) March 18, 2024 15:31
@eerhardt eerhardt merged commit 914760c into dotnet:main Mar 18, 2024
8 checks passed
@eerhardt eerhardt deleted the PasswordAPIs branch March 18, 2024 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants