[automated] Merge branch 'release/5.0' => 'master'

[dotnet-maestro-bot]

I detected changes in the release/5.0 branch which have not been merged yet to master. I'm a robot and am configured to help you automatically keep master up to date, so I've opened this PR.

This PR merges commits made on release/5.0 by the following committers:

• halter73
• dotnet-maestro[bot]

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/5.0
git pull --ff-only
git checkout master
git pull --ff-only
git merge --no-ff release/5.0

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-master

or if you are using SSH

git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-master

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/5.0-to-master'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/5.0-to-master master
git pull https://github.com/dotnet-maestro-bot/AspNetCore merge/release/5.0-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-master

or if you are using SSH

git checkout -b merge/release/5.0-to-master master
git pull [email protected]:dotnet-maestro-bot/AspNetCore merge/release/5.0-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-master

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

[ghost]

Auto-approving branch merge.

[ghost]

Hello @msftbot[bot]!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[dougbu]

Looks good but you or @TanayParikh will need to open this branch and use VS to add the new members to the API baseline files.

Or, @Pilchie should we remove the baseline files from 'master' until much later in the release❔

[Pilchie]

I’d prefer to keep them through the release so that we are more aware of when API surface area changes, though we should move the 5.0 APIs to the “Shipped” files.

[dougbu]

though we should move the 5.0 APIs to the “Shipped” files.

Soon 😺

[halter73]

I'm working through applying the analyzer suggestions using VS, but it's unbelievably slow. I'm going to try it on my office workstation to see if that helps but I'm not very hopeful. Is there any way to mass apply suggestions for "RS0036" analyzer suggestions without VS?

[dougbu]

Is there any way to mass apply suggestions for "RS0036" analyzer suggestions without VS?

Personally, I open the smallest containing *.slnf file for projects w/ errors and build. Then I navigate to one of the errors and use the fixer's entire solution option.

[Pilchie]

A commandline way of applying the fixes is a feature request, but I don't think it exists yet, right @mavasani ?

[mavasani]

A commandline way of applying the fixes is a feature request, but I don't think it exists yet, right @mavasani ?

That is correct, it has still not been implemented. Tagging @mikadumont @vatsalyaagrawal

[mikadumont]

A commandline way of applying the fixes

I went ahead and created an issue to be tracked here dotnet/roslyn#48561

[TanayParikh]

@dotnet/aspnet-build updated with the additional public api annotations, and now passing CI. Any objections in merging?

[dougbu]

@TanayParikh no objection from me. I'm surprised the public API is so different from what's in release/5.0 but everything seems to be working.

[Pilchie]

Tagging @pranavkm to take a look. Looks like a lot of these changes are to go from null-oblivious to null-annotated. Is that expected? Did we do more nullable work in master? Did a new arcade change a setting here or something?

[pranavkm]

We made changes to use nullable on generic type parameters late in 5.0. The changes make sense.

[TanayParikh]

Thanks all, merging.