Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove public members #26785

Closed
wants to merge 1 commit into from
Closed

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 11, 2020

  • !!! Do not merge !!!

- !!! Do not merge !!!
@dougbu dougbu added the * NO MERGE * Do not merge this PR as long as this label is present. label Oct 11, 2020
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 11, 2020
dougbu added a commit that referenced this pull request Oct 11, 2020
-  #26785 demonstrated analyzers were inoperable
@dougbu dougbu closed this Oct 11, 2020
@dougbu dougbu deleted the dougbu/check.api.changes branch October 11, 2020 20:53
dougbu added a commit that referenced this pull request Oct 12, 2020
* !!! Correct condition controlling `public` API analysis !!!
-  #26785 demonstrated analyzers were inoperable

* Remove unused `public` API files

* Update `public` API files
- three Components files were missing `#nullable enable`
- `nullable` annotations missing or out-of-date elsewhere

* Ignore `public` API files completely during source build
- do not warn about unused files

* Update more `public` API files
TanayParikh added a commit that referenced this pull request Oct 14, 2020
* Update dependencies from https://github.com/dotnet/runtime build 20201009.6 (#26755)

[release/5.0] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/efcore build 20201009.3 (#26764)

[release/5.0] Update dependencies from dotnet/efcore

* Add docs for Session, Diagnostics.EntityFrameworkCore, MiddlewareAnalysis and HeaderPropagation (#26720)

* Update dependencies from https://github.com/dotnet/runtime build 20201010.7 (#26792)

[release/5.0] Update dependencies from dotnet/runtime

* !!! Correct condition controlling `public` API analysis !!! (#26797)

* !!! Correct condition controlling `public` API analysis !!!
-  #26785 demonstrated analyzers were inoperable

* Remove unused `public` API files

* Update `public` API files
- three Components files were missing `#nullable enable`
- `nullable` annotations missing or out-of-date elsewhere

* Ignore `public` API files completely during source build
- do not warn about unused files

* Update more `public` API files

* Update dependencies from https://github.com/dotnet/efcore build 20201012.2 (#26816)

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer
 From Version 5.0.0-rtm.20509.3 -> To Version 5.0.0

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Quarantine flaky test (#26627)

* Stabilize package Versions for 5.0.0 (#26650)

- remove `$(DisableServicingFeatures)` property; `$(IsServicingBuild)` works now

* Remove unneeded package sources

* Fix PublicAPI.Unshipped.txt files to match source

* Fix PublicAPI.Unshipped.txt files to match source II

* Add <inheritdoc />

Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Stephen Halter <[email protected]>
Co-authored-by: Doug Bunting <[email protected]>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <[email protected]>
Co-authored-by: Tanay Parikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates * NO MERGE * Do not merge this PR as long as this label is present.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant