This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Revert changes to EncoderNLS/DecoderNLS.Convert unit tests #42829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabYourPitchforks
added
area-System.Text.Encoding
Servicing-consider
danmoseley
approved these changes
Jan 16, 2020
tarekgh
approved these changes
Jan 16, 2020
jamshedd
added
Servicing-approved
|
Approved for Feb. |
|
If #42832 merges, this can be closed. |
|
Thanks for taking care of it @ericstj. :) |
|
Went in as d658fef. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the unit test changes to accompany dotnet/coreclr#27996, which was committed to the release/3.1 branch in the coreclr repo.
This corefx PR isn't a functional product change. It's just updating the unit tests to reflect the incoming coreclr changes. Once a nightly coreclr build is created and it works its way into this repo, this PR will resolve the resulting unit test failures and will unblock future work in this repo.