Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/3.1] Update dependencies from dotnet/coreclr #42832

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/coreclr

  • Subscription: dbb830b1-8f81-460f-dd40-08d72a4caef5
  • Build: 20200115.4
  • Date Produced: 1/16/2020 3:43 AM
  • Commit: 4e29494f5610ecd739b1b762b36d3b93c61a4a4b
  • Branch: refs/heads/release/3.1
  • Updates:
    • Microsoft.NET.Sdk.IL -> 3.1.2-servicing.20065.4
    • Microsoft.NETCore.ILAsm -> 3.1.2-servicing.20065.4
    • Microsoft.NETCore.Runtime.CoreCLR -> 3.1.2-servicing.20065.4

…0115.4

- Microsoft.NET.Sdk.IL - 3.1.2-servicing.20065.4
- Microsoft.NETCore.ILAsm - 3.1.2-servicing.20065.4
- Microsoft.NETCore.Runtime.CoreCLR - 3.1.2-servicing.20065.4
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 16, 2020

Lots of test failures in System.Text here - @ahsonkhan @safern @ericstj who can take a look at this?

@wtgodbe
Copy link
Member

wtgodbe commented Jan 16, 2020

Presumably related to dotnet/coreclr@4e29494 - @GrabYourPitchforks PTAL

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@ericstj
Copy link
Member

ericstj commented Jan 16, 2020

@Anipik @GrabYourPitchforks it looks like we need to bring in the changes from #42829 does that sound correct?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@ericstj
Copy link
Member

ericstj commented Jan 16, 2020

I'm in office now, I will handle this.

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci, corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@danmoseley
Copy link
Member

I noticed that Fedora had the same 4 failures as all the others (I looked at the text log) it just didn't report it to AzDo perhaps because of this:

/root/helix/work/correlation/reporter/run.sh: line 26: /root/.vsts-env/bin/python: No such file or directory
+ date -u +%FT%TZ
2020-01-16T10:40:01Z
+ python /root/helix/work/correlation/xunit-reporter.py
Traceback (most recent call last):
  File "/root/helix/work/correlation/xunit-reporter.py", line 5, in <module>
    import helix.azure_storage
  File "/root/helix/scripts/helix/azure_storage.py", line 49
    def _create_write_url(self, file_name: str) -> str:
                                         ^
SyntaxError: invalid syntax
+ exit 1
+ export _commandExitCode=1
+ _commandExitCode=1
+ chmod -R 777 /home/helixbot/dotnetbuild/dumps
+ exit 1

@dotnet/dnceng

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Windows Build UWP_CoreCLR_x64_Debug), corefx-ci (Windows Build NETFX_x86_Release), corefx-ci (Windows Build x86_Release), corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build RedHat6_x64_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@ericstj
Copy link
Member

ericstj commented Jan 16, 2020

@MattGal should we open an issue somewhere about Fedora machines missing Python?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci (MacOS Build x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@danmoseley
Copy link
Member

@MattGal should we open an issue somewhere about Fedora machines missing Python?

It looks like the problem is that it's picking up Python 2, not Python 3. (Named parameters are apparently introduced in Python 3)

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci (MacOS Build x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@danmoseley
Copy link
Member

Had a quick look at the macOS failures -- the networking tests passed, but infra failed; the crypto tests left no log. Opened linked issues for both.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: corefx-ci (MacOS Build x64_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 16, 2020

Getting Helix timeouts, but we have test coverage from the other legs.

@wtgodbe wtgodbe merged commit d658fef into release/3.1 Jan 16, 2020
@wtgodbe wtgodbe deleted the darc-release/3.1-c91eb5f7-cd76-48be-9294-a78cae3d73ec branch January 16, 2020 21:36
@garath
Copy link
Member

garath commented Jan 16, 2020

Getting Helix timeouts, but we have test coverage from the other legs.

It looks like the Windows 7 open queue failed to scale-up for several hours. It's fully scaled-up now, so I expect this is a transient Azure issue. We'll keep an eye on it.

@shawnro
Copy link
Member

shawnro commented Jan 16, 2020

@MattGal should we open an issue somewhere about Fedora machines missing Python?

It looks like the problem is that it's picking up Python 2, not Python 3. (Named parameters are apparently introduced in Python 3)

What about this? Is this still an issue?

@danmoseley
Copy link
Member

I'll open a core-eng issue for it.

@danmoseley
Copy link
Member

@MattGal
Copy link
Member

MattGal commented Jan 17, 2020

Put some notes into that issue, TL;DR: An upgrade to mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-29-helix-a12566d-20191210224553 should unblock you but we can't change these docker files any more as they were deleted when the OS EOL'ed. See me if you have questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants