Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More TPT tests #21510

Closed
smitpatel opened this issue Jul 3, 2020 · 0 comments · Fixed by #21537
Closed

More TPT tests #21510

smitpatel opened this issue Jul 3, 2020 · 0 comments · Fixed by #21537
Assignees
@smitpatel
Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

Convert following test classes to use TPT in hierarchy as another flavor

  • ManyToMany - Skip navs
  • GearsOfWar - composite keys in hierarchy, query compositions, split queries
  • FilterInheritance - Query filters

Also add split query tests to TPTRelationships for some coverage over TPT having owned collections.
@smitpatel smitpatel self-assigned this Jul 3, 2020
@smitpatel smitpatel mentioned this issue Jul 3, 2020
Closed
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jul 6, 2020
smitpatel added a commit that referenced this issue Jul 6, 2020
@smitpatel
Query: Add TPT variant for GearsOfWarQueryTests
21e2255 
Part of #21510
@smitpatel smitpatel mentioned this issue Jul 6, 2020
Merged
smitpatel added a commit that referenced this issue Jul 6, 2020
@smitpatel
Query: Add TPT variant for FilterInheritanceQueryTests
83e3977 
Part of #21510
@smitpatel smitpatel mentioned this issue Jul 6, 2020
Merged
smitpatel added a commit that referenced this issue Jul 6, 2020
@smitpatel
Query: Add TPT variation for ManyToMany tests
1765d2f 
This also cover some split queries

Part of #21510
@smitpatel smitpatel mentioned this issue Jul 6, 2020
Merged
smitpatel added a commit that referenced this issue Jul 6, 2020
@smitpatel
Query: Add TPT variation for ManyToMany tests
8506c4c 
This also cover some split queries

Part of #21510
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2020
smitpatel added a commit that referenced this issue Jul 6, 2020
@smitpatel
Query: Add split query tests in TPT relationship tests
9d938c7 
Resolves #21510
@smitpatel smitpatel mentioned this issue Jul 6, 2020
Merged
smitpatel added a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add TPT variant for GearsOfWarQueryTests
afede2f 
Part of #21510
smitpatel added a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add TPT variant for FilterInheritanceQueryTests
f785389 
Part of #21510
smitpatel added a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add split query tests in TPT relationship tests
f9047e3 
Resolves #21510
@ghost ghost closed this as completed in #21537 Jul 7, 2020
ghost pushed a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add split query tests in TPT relationship tests (#21537)
39e8b17 
Resolves #21510
smitpatel added a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add TPT variation for ManyToMany tests
213f0c4 
This also cover some split queries

Part of #21510
ghost pushed a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add TPT variant for GearsOfWarQueryTests (#21532)
230ac18 
Part of #21510
ghost pushed a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add TPT variant for FilterInheritanceQueryTests (#21533)
d564699 
Part of #21510
ghost pushed a commit that referenced this issue Jul 7, 2020
@smitpatel
Query: Add TPT variation for ManyToMany tests (#21534)
f5bafa6 
This also cover some split queries

Part of #21510
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Add split query tests in TPT relationship tests dotnet/efcore
2 participants
@ajcvickers @smitpatel