Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add TPT variation for ManyToMany tests #21534

Merged
1 commit merged into from
Jul 7, 2020
Merged

Query: Add TPT variation for ManyToMany tests #21534

1 commit merged into from
Jul 7, 2020

Conversation

smitpatel
Copy link
Contributor

This also cover some split queries

Part of #21510

@smitpatel smitpatel requested a review from a team July 6, 2020 19:46
AndriySvyryd
AndriySvyryd reviewed Jul 7, 2020
View reviewed changes
test/EFCore.Sqlite.FunctionalTests/Query/TPTManyToManyQuerySqliteTest.cs Outdated

public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(bool async) => Task.CompletedTask;

[ConditionalTheory(Skip = "SQLite bug")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be more specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied over from non-TPT M2M thing. I believe underlying sqlite3 had some issue, let me see if I can track it down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #21541

@smitpatel smitpatel force-pushed the smit/filtersInheritance branch from 83e3977 to f785389 Compare July 7, 2020 04:15
@smitpatel
Query: Add TPT variation for ManyToMany tests
213f0c4 
This also cover some split queries

Part of #21510
@smitpatel smitpatel changed the base branch from smit/filtersInheritance to master July 7, 2020 04:30
@ghost
Copy link

ghost commented Jul 7, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@smitpatel
Copy link
Contributor Author

@msftbot delay merging this pull request for 2 hours 50 mins

@ghost
Copy link

ghost commented Jul 7, 2020

Hello @smitpatel!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 07 Jul 2020 07:21:50 GMT, which is in 2 hours and 50 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit f5bafa6 into master Jul 7, 2020
@ghost ghost deleted the smit/many2many branch July 7, 2020 07:22
@ajcvickers ajcvickers mentioned this pull request Jul 9, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @AndriySvyryd