Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'main' => 'release/dev17.14' #18339

Open
wants to merge 6 commits into
base: release/dev17.14
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

I detected changes in the main branch which have not been merged yet to release/dev17.14. I'm a robot and am configured to help you automatically keep release/dev17.14 up to date, so I've opened this PR.

This PR merges commits made on main by the following committers:

  • T-Gro
  • vzarytovskii

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout main
git pull --ff-only
git checkout release/dev17.14
git pull --ff-only
git merge --no-ff main

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-release/dev17.14
or if you are using SSH
git push [email protected]:dotnet/fsharp HEAD:merge/main-to-release/dev17.14

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-release/dev17.14'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/main-to-release/dev17.14 origin/release/dev17.14
git pull https://github.com/dotnet/fsharp merge/main-to-release/dev17.14
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/fsharp HEAD:merge/main-to-release/dev17.14
or if you are using SSH
git fetch
git checkout -b merge/main-to-release/dev17.14 origin/release/dev17.14
git pull [email protected]:dotnet/fsharp merge/main-to-release/dev17.14
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet/fsharp HEAD:merge/main-to-release/dev17.14

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

vzarytovskii and others added 4 commits February 24, 2025 12:22
* Warn when 'unit' is passed to an 'obj' argument

* fantomas of the opera

* notes + fix build of tests

* Apply suggestions from code review

Co-authored-by: Adam Boniecki <[email protected]>

* Address test warnings

* Fix tests

* revert to stable warning when arg is other than obj

---------

Co-authored-by: Adam Boniecki <[email protected]>
Co-authored-by: Petr <[email protected]>
@github-actions github-actions bot requested a review from a team as a code owner February 25, 2025 11:57
… type instantiations (#18337)

* issue analysis

* No nullness warning if override passes in explicit nullable type argument

* notes
@T-Gro T-Gro enabled auto-merge February 25, 2025 12:29
Copy link
Contributor Author

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md No current pull request URL (#18339) found, please consider adding it
LanguageFeatures.fsi docs/release-notes/.Language/preview.md No current pull request URL (#18339) found, please consider adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants