Consider pure functions as part of CA1806. #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@333fred I'd be interested in gathering some churn metrics in some common cases for this change. For example, how many more diagnostics were reported due to this change in:
|
|
@sharwell investigated:
|
|
Ping @sharwell @dotnet/roslyn-analysis for review here. |
mavasani
reviewed
May 3, 2017
| @@ -6,6 +6,8 @@ | |||
| using Microsoft.CodeAnalysis; | |||
| using Microsoft.CodeAnalysis.Diagnostics; | |||
| using Microsoft.CodeAnalysis.Semantics; | |||
| using System.Diagnostics.Contracts; | |||
mavasani
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that are marked
Purehave no side effects, and should be considered when we check to see if function results are discarded without use. Fixes #1164. Tagging @dotnet/analyzer-ioperation @sharwell for review.