Add object browser support for ref struct interfaces (#73621)

* Add object browser support for ref struct interfaces The description building code for method constraints in the object browser had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: #72124 This ref structs for interfaces feature was merged via this PR: #73567
dotnet · May 22, 2024 · b8395ee · b8395ee
1 parent 35e4223
commit b8395ee
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 5 deletions.
diff --git a/src/VisualStudio/CSharp/Impl/ObjectBrowser/DescriptionBuilder.cs b/src/VisualStudio/CSharp/Impl/ObjectBrowser/DescriptionBuilder.cs
@@ -342,7 +342,8 @@ private void BuildConstraints(ITypeParameterSymbol typeParameterSymbol)
             if (typeParameterSymbol.ConstraintTypes.Length == 0 &&
                 !typeParameterSymbol.HasConstructorConstraint &&
                 !typeParameterSymbol.HasReferenceTypeConstraint &&
-                !typeParameterSymbol.HasValueTypeConstraint)
+                !typeParameterSymbol.HasValueTypeConstraint &&
+                !typeParameterSymbol.AllowsRefLikeType)
             {
                 return;
             }
@@ -396,6 +397,17 @@ private void BuildConstraints(ITypeParameterSymbol typeParameterSymbol)
                 }
 
                 AddText("new()");
+                isFirst = false;
+            }
+
+            if (typeParameterSymbol.AllowsRefLikeType)
+            {
+                if (!isFirst)
+                {
+                    AddComma();
+                }
+
+                AddText("allows ref struct");
             }
         }
 

diff --git a/src/VisualStudio/Core/Test/ObjectBrowser/CSharp/ObjectBrowerTests.vb b/src/VisualStudio/Core/Test/ObjectBrowser/CSharp/ObjectBrowerTests.vb
@@ -728,13 +728,18 @@ $"    {String.Format(ServicesVSResources.Member_of_0, "UnsafeC")}")
 using System.Collections.Generic;
 class C
 {
-    T M&lt;T, U, V&gt;()
+    T M1&lt;T, U, V&gt;()
         where T : class, new()
         where U : V
         where V : List&lt;T&gt;
     {
         return null;
     }
+
+    void M2&lt;T&gt;(T t)
+        where T : IDisposable, allows ref struct
+    {
+    }
 }
 </Code>
 
@@ -744,12 +749,19 @@ class C
                 list = list.GetTypeList(0)
                 list = list.GetMemberList(0)
 
-                list.VerifyImmediateMemberDescriptions(
-"private T M<T, U, V>()" & vbCrLf &
+                Dim memberDescription1 =
+"private T M1<T, U, V>()" & vbCrLf &
 vbTab & "where T : class, new()" & vbCrLf &
 vbTab & "where U : V" & vbCrLf &
 vbTab & "where V : System.Collections.Generic.List<T>" & vbCrLf &
-$"    {String.Format(ServicesVSResources.Member_of_0, "C")}")
+$"    {String.Format(ServicesVSResources.Member_of_0, "C")}"
+
+                Dim memberDescription2 =
+"private void M2<T>(T t)" & vbCrLf &
+vbTab & "where T : IDisposable, allows ref struct" & vbCrLf &
+$"    {String.Format(ServicesVSResources.Member_of_0, "C")}"
+
+                list.VerifyImmediateMemberDescriptions(memberDescription1, memberDescription2)
             End Using
         End Sub