-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch 'features/RefStructInterfaces' into 'main' #73567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" during constraints check. (dotnet#72537)
…tatements (dotnet#72810) Corresponding spec update - dotnet/csharplang#8024
…struct' constraint (dotnet#73025)
…struct' constraint (dotnet#73059)
…struct' constraint (dotnet#73111)
…struct' constraint (dotnet#73232) Also related to dotnet#73242.
…struct' constraint (dotnet#73305)
…struct' constraint (dotnet#73363)
jaredpar
approved these changes
May 17, 2024
This was referenced May 21, 2024
ToddGrun
added a commit
that referenced
this pull request
May 21, 2024
The method extraction code uses ITypeParameterSymbol's constraints to generate the new method's text. This codepath had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: #72124 This ref structs for interfaces feature was merged via this PR: #73567
ToddGrun
added a commit
to ToddGrun/roslyn
that referenced
this pull request
May 21, 2024
The description building code for method constraints in the object browser had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: dotnet#72124 This ref structs for interfaces feature was merged via this PR: dotnet#73567
ToddGrun
added a commit
to ToddGrun/roslyn
that referenced
this pull request
May 22, 2024
The selected display part building code for method constraints in signature help had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: dotnet#72124 This ref structs for interfaces feature was merged via this PR: dotnet#73567
ToddGrun
added a commit
that referenced
this pull request
May 22, 2024
* Add extract method support for ref struct interfaces The method extraction code uses ITypeParameterSymbol's constraints to generate the new method's text. This codepath had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: #72124 This ref structs for interfaces feature was merged via this PR: #73567
ToddGrun
added a commit
that referenced
this pull request
May 22, 2024
The selected display part building code for method constraints in signature help had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: #72124 This ref structs for interfaces feature was merged via this PR: #73567
ToddGrun
added a commit
that referenced
this pull request
May 22, 2024
* Add object browser support for ref struct interfaces The description building code for method constraints in the object browser had not yet been modified to support ITypeParameterSymbol.AllowsRefLikeType This is in support of the "allows ref struct" on interfaces feature outlined here: #72124 This ref structs for interfaces feature was merged via this PR: #73567
5 tasks
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Jul 30, 2024
The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Jul 30, 2024
The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Jul 31, 2024
The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages.
BillWagner
added a commit
to dotnet/docs
that referenced
this pull request
Jul 31, 2024
…rfaces (#41948) * Add, update messages in dotnet/roslyn#73567 The PR for `ref struct` interfaces added new compiler error and warning messages. It also updates a few messages. This commit creates the stubs for the new messages, and updates the text for updated messages. * incorporate additional ref struct error conditions * Edit pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Compilers
Feature - RefStructInterfaces
untriaged
Issues and PRs which have not yet been triaged by a lead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.