{vis}[foss/2018a] gnuplot v5.2.2 #5955

reedts · 2018-03-06T11:54:08Z

(created using eb --new-pr)
Edit: depends on ~~#5988~~, ~~#5987~~, ~~#5979~~, ~~#5980~~

boegel · 2018-03-06T19:58:18Z

easybuild/easyconfigs/l/libgd/libgd-2.2.4-GCCcore-6.4.0.eb

-    ('libpng', '1.6.32'),
+    ('fontconfig', '2.12.6'),
+    ('libjpeg-turbo', '1.5.3'),
+    ('libpng', '1.6.34'),


@reedts Please don't bump dependency versions in existing easyconfig, you'll introduce conflicts in other places...

I'll take it out

@reedts You want to add a new easyconfig for libgd 2.2.5, not change the existing one for 2.2.4` in place...

Ah I found an error in my libgd-2.2.5 easyconfig. The version there was still 2.2.4. Seems like it messed things up...

boegel · 2018-03-06T19:59:24Z

@reedts This PR is getting quite big, to the point where it's going to be difficult to get it merged. A rule of thumb is to not include/tweak more than 10 easyconfigs per PR.

Can you flesh out some of this in a separate PR?

reedts · 2018-03-09T08:50:37Z

@boegel I agree, I'll restructure this and split it up into several PRs.

boegel · 2018-03-09T09:11:47Z

@reedts You may not need to, see PRs for Mesa 17.3.6 (~~#5973~~) and cairo 1.14.12 (#5979)

reedts · 2018-03-09T09:50:40Z

@boegel Removed the Mesa and cairo packages. The other easyconfigs are already outsourced in other PRs, see updated PR description.

Read this too late, sorry..

boegel · 2018-03-09T17:37:26Z

easybuild/easyconfigs/l/libgd/libgd-2.2.4-GCCcore-6.4.0.eb

-easyblock = 'ConfigureMake'
-
-name = 'libgd'
-version = '2.2.4'


@reedts Please don't remove existing easyconfigs...

@boegel My fault. Looks like I have to re-add it to remove it?

boegel · 2018-03-09T17:42:03Z

easybuild/easyconfigs/l/libdrm/libdrm-2.4.90-GCCcore-6.4.0.eb

+easyblock = 'ConfigureMake'
+
+name = 'libdrm'
+version = '2.4.90'


@reedts We already have an existing easyconfig for libdrm 2.4.91, which is more recent than this...

Also, this is not related to gnuplot at all? So can just be removed imho...

@boegel Right, it must have got in here somehow. I'll remove it.

boegel · 2018-03-12T16:06:22Z

@reedts All PRs this PR depends on are now merged, I've retriggered the tests in Travis to get a better view on current status.

This reverts commit c2304a1.

boegel · 2018-03-13T09:20:55Z

easybuild/easyconfigs/g/gnuplot/gnuplot-5.2.2-foss-2018a.eb

+    ('cairo', '1.14.12'),
+    ('libjpeg-turbo', '1.5.3'),
+    ('libpng', '1.6.34'),
+    ('libgd', '2.2.5'),


@reedts Easyconfig file for this libgd dep is still missing?

@boegel Should be included now.

looks good now indeed 👍

boegel · 2018-03-13T09:30:30Z

easybuild/easyconfigs/l/libgd/libgd-2.2.4-GCCcore-6.4.0.eb

-    ('libpng', '1.6.32'),
+    ('fontconfig', '2.12.6'),
+    ('libjpeg-turbo', '1.5.3'),
+    ('libpng', '1.6.34'),


@reedts You want to add a new easyconfig for libgd 2.2.5, not change the existing one for 2.2.4` in place...

boegel · 2018-03-13T10:31:51Z

easybuild/easyconfigs/l/libgd/libgd-2.2.5-GCCcore-6.4.0.eb

@@ -1,7 +1,7 @@
 easyblock = 'ConfigureMake'

 name = 'libgd'
-version = '2.2.4'
+version = '2.2.5'


@reedts You're now renaming the libgd 2.2.4 easyconfig to 2.2.5, which means removing the 2.2.4 easyconfig...

Also, the checksum for libgd 2.2.5 needs to be fixed.

@boegel I fixed the checksum but still struggling to get that version 2.2.4 out. Will removing it and readding it work (before I try and it still won't work)?

@reedts Just re-adding it should do it (you can't remove it anymore, it's already gone since it was renamed to 2.2.5).

boegel · 2018-03-13T11:03:08Z

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2666.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/0a05880852fc61f494e8733666301d7c for a full test report.

boegel · 2018-03-13T11:10:19Z

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2040.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/93e7a071f9b61cc10882198663dfd9ed for a full test report.

boegel · 2018-03-13T11:33:45Z

@reedts Tests complain that both libjpeg-turbo 1.5.2 and 1.5.3 are now used as deps in foss/2018a easyconfigs (thanks to the added check in #5970), which is an issue with the just merged GraphicsMagick & Ghostscript easyconfigs from #5982, not this gnuplot PR.

I'm fixing that in #5999, I will re-trigger the tests here once that PR is merged.

reedts · 2018-03-13T11:40:02Z

@boegel All right! Good that check exists now in the first place!

boegel · 2018-03-13T15:26:09Z

@reedts Seems like you'll need to sync your branch with current develop...

boegel · 2018-03-14T12:50:01Z

@reedts Please merge reedts#1 so we can get this PR merged?

sync with develop

reedts · 2018-03-15T08:48:50Z

@boegel Merged.

boegel · 2018-03-15T10:04:42Z

Going in, thanks @reedts!

reedts added 5 commits March 6, 2018 12:53

Updated gnuplot and dependencies

7510479

Added missing checksums

f08b0b8

Fixed blank line at end of file

090841a

Fixed easyconfig

af2390b

Added missing dependencies

c96e2e1

boegel reviewed Mar 6, 2018

View reviewed changes

boegel added the update label Mar 6, 2018

Removed existing easyconfigs

c2304a1

reedts added 2 commits March 9, 2018 10:28

Removed dependencies

a281340

Removed duplicated easyconfigs

b1e0beb

Added Pango and FriBidi easyconfigs

360db52

easybuilders deleted a comment from boegelbot Mar 9, 2018

boegel added this to the 3.6.0 milestone Mar 9, 2018

boegel requested changes Mar 9, 2018

View reviewed changes

easybuilders deleted a comment from boegelbot Mar 9, 2018

easybuilders deleted a comment from boegelbot Mar 12, 2018

reedts added 5 commits March 13, 2018 09:51

Removed easyconfig for libdrm

764efff

Revert "Removed existing easyconfigs"

a2ce35b

This reverts commit c2304a1.

Removed easyconfig for libgd

a565958

Removed easyconfig for libgd

ce0f88a

Removed empty line

cac8f55

boegel reviewed Mar 13, 2018

View reviewed changes

Added missing libgd 2.2.5

deb5764

boegel requested changes Mar 13, 2018

View reviewed changes

Fixed libgd dependency

cd8059f

boegel requested changes Mar 13, 2018

View reviewed changes

reedts added 2 commits March 13, 2018 11:50

Do not remove libgd-2.2.4

3ed7de9

Fixed checksum

54ff2e9

boegel previously approved these changes Mar 13, 2018

View reviewed changes

boegel mentioned this pull request Mar 13, 2018

use latest libjpeg-turbo 1.5.3 in GraphicsMagick/Ghostscript foss/2018a easyconfigs #5999

Merged

easybuilders deleted a comment from boegelbot Mar 13, 2018

Merge branch 'develop' into 20180306125256_new_pr_cairo11412

3ddd920

boegel mentioned this pull request Mar 13, 2018

sync with develop reedts/easybuild-easyconfigs#1

Merged

add empty line above 'toolchain' line in gnuplot/FriBidi easyconfigs

19b8ece

boegel mentioned this pull request Mar 14, 2018

{vis}[foss/2018a] GTK+ 2.24.32 #5827

Merged

Merge pull request #1 from boegel/20180306125256_new_pr_cairo11412

87f3a7b

sync with develop

reedts dismissed boegel’s stale review via 87f3a7b March 15, 2018 08:48

boegel approved these changes Mar 15, 2018

View reviewed changes

boegel merged commit e951ee3 into easybuilders:develop Mar 15, 2018

easybuilders deleted a comment from boegelbot Mar 15, 2018

boegel mentioned this pull request Mar 15, 2018

{math}[foss/2018a] Octave 4.2.1 + deps #6018

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{vis}[foss/2018a] gnuplot v5.2.2 #5955

{vis}[foss/2018a] gnuplot v5.2.2 #5955

reedts commented Mar 6, 2018 •

edited by boegel

Loading

boegel Mar 6, 2018

reedts Mar 9, 2018

boegel Mar 13, 2018

reedts Mar 13, 2018

boegel commented Mar 6, 2018

reedts commented Mar 9, 2018

boegel commented Mar 9, 2018

reedts commented Mar 9, 2018

boegel Mar 9, 2018

reedts Mar 13, 2018

boegel Mar 9, 2018

reedts Mar 13, 2018

boegel commented Mar 12, 2018

boegel Mar 13, 2018

reedts Mar 13, 2018

boegel Mar 13, 2018

boegel Mar 13, 2018

boegel Mar 13, 2018

reedts Mar 13, 2018

boegel Mar 13, 2018

boegel commented Mar 13, 2018

boegel commented Mar 13, 2018

boegel commented Mar 13, 2018

reedts commented Mar 13, 2018

boegel commented Mar 13, 2018

boegel commented Mar 14, 2018

reedts commented Mar 15, 2018

boegel commented Mar 15, 2018

{vis}[foss/2018a] gnuplot v5.2.2 #5955

{vis}[foss/2018a] gnuplot v5.2.2 #5955

Conversation

reedts commented Mar 6, 2018 • edited by boegel Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boegel commented Mar 6, 2018

reedts commented Mar 9, 2018

boegel commented Mar 9, 2018

reedts commented Mar 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boegel commented Mar 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boegel commented Mar 13, 2018

boegel commented Mar 13, 2018

boegel commented Mar 13, 2018

reedts commented Mar 13, 2018

boegel commented Mar 13, 2018

boegel commented Mar 14, 2018

reedts commented Mar 15, 2018

boegel commented Mar 15, 2018

reedts commented Mar 6, 2018 •

edited by boegel

Loading