Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add show hidden option to outputs panel #1209
base: develop
Are you sure you want to change the base?
feat: add show hidden option to outputs panel #1209
Changes from 13 commits
0e374f2
182fa42
4da0ce1
fa59f8e
bc35ee1
c382a3c
468e572
79109b8
6508c6a
851028f
edd431a
fb30fe8
d1fa6fb
c448b0b
487360c
cdf65fd
3205f8c
c17febe
d5fcd50
3eda87f
0b9d8fd
c1084b1
af7fa84
bb88a4e
446970f
d25f257
34fd9ac
9484389
5c42f3c
c7b4ff7
a9af8a9
81d904e
b0cf956
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings like this need to be localizable, so it should move to "en.yaml" and consumed with
$t(app....)
so it can be translatedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, forgot to do that. will fix it this weekend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also make this "Show hidden outputs" to make it more descriptive and distinct from any other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, got the other things done. where do you recomend putting this in the translation files?