Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify JobMapComposables further by pulling logic out of view layers #3045

Merged
merged 13 commits into from
Feb 12, 2025

Merge remote-tracking branch 'upstream/ashobhit/map-composable-cleanu…

024381c
Select commit
Loading
Failed to load commit list.
Merged

Simplify JobMapComposables further by pulling logic out of view layers #3045

Merge remote-tracking branch 'upstream/ashobhit/map-composable-cleanu…
024381c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 12, 2025 in 0s

62.89% (+0.16%) compared to 2c83072

View this Pull Request on Codecov

62.89% (+0.16%) compared to 2c83072

Details

Codecov Report

Attention: Patch coverage is 42.59259% with 31 lines in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (2c83072) to head (024381c).

Files with missing lines Patch % Lines
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 36.36% 15 Missing and 6 partials ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 28.57% 3 Missing and 2 partials ⚠️
...id/ground/ui/home/mapcontainer/jobs/LoiJobSheet.kt 0.00% 4 Missing ⚠️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3045      +/-   ##
============================================
+ Coverage     62.73%   62.89%   +0.16%     
+ Complexity     1300     1298       -2     
============================================
  Files           278      278              
  Lines          6792     6768      -24     
  Branches        947      949       +2     
============================================
- Hits           4261     4257       -4     
+ Misses         1910     1890      -20     
  Partials        621      621
Files with missing lines Coverage Δ
.../mapcontainer/jobs/DataCollectionEntryPointData.kt 100.00% <100.00%> (ø)
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 56.96% <80.00%> (-0.38%) ⬇️
...id/ground/ui/home/mapcontainer/jobs/LoiJobSheet.kt 0.00% <0.00%> (ø)
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 17.42% <28.57%> (-0.23%) ⬇️
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 28.16% <36.36%> (-6.40%) ⬇️
View more details on Codecov