Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify JobMapComposables further by pulling logic out of view layers #3045

Merged
merged 13 commits into from
Feb 12, 2025

Merge remote-tracking branch 'upstream/ashobhit/map-composable-cleanu…

024381c
Select commit
Loading
Failed to load commit list.
Merged

Simplify JobMapComposables further by pulling logic out of view layers #3045

Merge remote-tracking branch 'upstream/ashobhit/map-composable-cleanu…
024381c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 12, 2025 in 1s

42.59% of diff hit (within 60.00% threshold of 62.73%)

View this Pull Request on Codecov

42.59% of diff hit (within 60.00% threshold of 62.73%)

Annotations

Check warning on line 80 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt#L80 

Added line #L80 was not covered by tests

Check warning on line 62 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L60-L62 

Added lines #L60 - L62 were not covered by tests

Check warning on line 64 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L64 

Added line #L64 was not covered by tests

Check warning on line 75 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L74-L75 

Added lines #L74 - L75 were not covered by tests

Check warning on line 94 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L94 

Added line #L94 was not covered by tests

Check warning on line 97 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L97 

Added line #L97 was not covered by tests

Check warning on line 99 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L99 

Added line #L99 was not covered by tests

Check warning on line 101 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L101 

Added line #L101 was not covered by tests

Check warning on line 119 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L119 

Added line #L119 was not covered by tests

Check warning on line 143 in app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/com/google/android/ground/ui/home/mapcontainer/jobs/JobMapComposables.kt#L141-L143 

Added lines #L141 - L143 were not covered by tests
View more details on Codecov