Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from project all filter lists which are not selected by default #602

Closed
gorhill opened this issue Aug 16, 2015 · 6 comments
Closed

Comments

@gorhill
Copy link
Owner

gorhill commented Aug 16, 2015

They cause the package to be too large.

The 3rd-party filters pane will still allow to easily select these non-default 3rd-party filter lists, only difference is that they will have to be downloaded the first time they are selected (this already happens anyway for most 3rd-party filter lists -- to fetch latest versions). A couple of current stock 3rd-party filter lists are already natively remotely fetched (not part of uBlock's package).

The transition needs to be completely transparent to users (as in nothing to do), and this requires filter-lists.json to be backward compatible until all uBlock Origin installations have been updated to deal with the filter lists which are now pointing strictly to their remote locations.

@charlesay
Copy link

i was about to ask for the implementation of a 'select all' option, which would be useful but partially moot if this change occurs

@gorhill
Copy link
Owner Author

gorhill commented Aug 16, 2015

I would have not accepted to implement such feature anyways.

@charlesay
Copy link

ok, why not (out of interest)?

@gorhill
Copy link
Owner Author

gorhill commented Aug 16, 2015

Common sense (see Tips). The question is rather why would someone want to do this?

@charlesay
Copy link

couldn't it be faster to deselect the undesired or -necessary lists than selecting individually the ones that should be active. i haven't compared the content of the lists in detail so, it could mostly be pointless i suppose.

gorhill added a commit that referenced this issue Aug 17, 2015
- When #602 is completely fixed, the only filter lists packaged with the
  extension will be those which are selected by default out-of-the-box. So
  scripts to update 3rd-party assets have been changed for this.
- Removed "bad" filter lists:
    - "ESP: Filtros Nauscopicos": no longer maintained
    - "ROU: RO-LIST": contains questionable exception filters.
      (See: uBlock-LLC/uBlock#693)
gorhill added a commit that referenced this issue Aug 17, 2015
All the assets which are not selected by default out-of-the-box will
be converted into an empty file. This is a first step, the final step
will be to removed completely the files from the package once everybody
is using v1.1.0.0+.
@gorhill
Copy link
Owner Author

gorhill commented Aug 25, 2015

Fixed in efccaf1.

@gorhill gorhill closed this as completed Aug 25, 2015
gorhill added a commit that referenced this issue Aug 25, 2015
External filter lists are not meant to appear in checksums.txt.
gorhill added a commit that referenced this issue Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants