Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix https://github.com/chrisaljoudi/uBlock/issues/1520 #643

Closed
wants to merge 1 commit into from
Closed

fix https://github.com/chrisaljoudi/uBlock/issues/1520 #643

wants to merge 1 commit into from

Conversation

publicarray
Copy link

undoes uBlock-LLC/uBlock@3248b8d because @@googleads.g.doubleclick.net is no longer in the latest list

@gorhill
Copy link
Owner

gorhill commented Aug 26, 2015

This is an obsolete issue for uBlock Origin as of 1.1.0.0. Refer to #602.

@gorhill gorhill closed this Aug 26, 2015
@publicarray
Copy link
Author

Sorry I should have tested with the latest dev version.

@publicarray publicarray deleted the patch-1 branch August 26, 2015 13:18
@publicarray
Copy link
Author

I am a bit confused. So is the homeURL variable isn't used for updates anymore?
EDIT
I am confused because in FF and uBlock Origin v1.1.0.0 from github the assets viewer url i get is chrome://ublock0/content/asset-viewer.html?url=https://adblock.schack.dk/block.txt. how does uBlock know the URL and that it has to use the https protocol when its only saved in the file itself ! redirect: http://adblock.dk/block.csv note the http protocol. I also fired up the logger which showed the request as https, when I purge the cache.

@gorhill
Copy link
Owner

gorhill commented Aug 26, 2015

For backward compatibility purpose, filter-lists.json is itself left unchanged, but it is internally re-generated to use the new URLs. As you can see, assets/thirdparties/adblock.schack.dk/block.txt is being re-mapped to https://adblock.schack.dk/block.txt.

When the list "key" is a valid external URL, the homeURL property is pointless (and so does not exist), homeURL is implicitly the list "key" itself.

@publicarray
Copy link
Author

Thank you for the explanation.
p.s. I really enjoy your extension keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants