re-added a removed testcase #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utilizing a removed test that tests proper testing functionality
|
The PR should have been made to the ensf400-ws24 branch, not to main. |
growlf
requested changes
Feb 25, 2024
| @@ -3,5 +3,5 @@ | |||
| def test_always_passes(): | |||
| assert True | |||
|
|
|||
| # def test_always_fails(): | |||
| # assert False | |||
| def test_always_fails(): | |||
There was a problem hiding this comment.
This change will cause the CI/CD workflow to always fail, and cannot be accepted as-is. There are valid reasons to use such, but additional code that uses assert to allow for false failures would also be required and is not represented in this commit.
| "editor.fontFamily": "'MesloLGS NF', 'Droid Sans Mono', 'monospace', monospace", | ||
| "python.testing.pytestArgs": ["tests"], | ||
| "python.testing.unittestEnabled": false, |
There was a problem hiding this comment.
Usually, we use only one of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uncommented the always fail test case, that I'm pretty sure is used to test if the test package is operating correctly.