Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-added a removed testcase #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"editor.fontFamily": "'MesloLGS NF', 'Droid Sans Mono', 'monospace', monospace"
}
"editor.fontFamily": "'MesloLGS NF', 'Droid Sans Mono', 'monospace', monospace",
"python.testing.pytestArgs": ["tests"],
"python.testing.unittestEnabled": false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we use only one of these.

"python.testing.pytestEnabled": true
}
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ Some possible tasks to add-to/replace the default options:
- setup a reverse proxy for remote shell (outbond from container host to remote support system)
- create a container project from defined template


## Use with Portainer

Use the `portainer-compose.yml` file and modify to your hearts content.

## Notes

- https://ohmyz.sh/#install
Expand Down
4 changes: 2 additions & 2 deletions tests/baseline_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
def test_always_passes():
assert True

# def test_always_fails():
# assert False
def test_always_fails():
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will cause the CI/CD workflow to always fail, and cannot be accepted as-is. There are valid reasons to use such, but additional code that uses assert to allow for false failures would also be required and is not represented in this commit.

assert False