runtime: rewrite query.go in new protoreflect

[johanbrandhorst]

Replaces lots of go reflection with protoreflect from APIv2. This is an essential part of rooting out the old API from our packages. Unfortunately, we also lose the capability to support gogoproto stdtime and stdduration types, since they cannot be represented in the new reflection interface.

If you do want to review this, I suggest opening the new file separately, the diff is mostly unhelpful since it's a complete rewrite.

[dsnet]

Changes overall look good to me.

[johanbrandhorst]

EDIT: worked around this issue by avoiding ptypes.

Seeing a really strange bazel build error:

[396 / 639] 1 / 10 tests; GoCompilePkg external/org_golang_google_grpc/internal/channelz/linux_amd64_race_stripped/go_default_library%/google.golang.org/grpc/internal/channelz.a; 1s processwrapper-sandbox ... (16 actions running)
ERROR: /src/grpc-gateway/runtime/BUILD.bazel:5:1: GoCompilePkg runtime/linux_amd64_race_stripped/go_default_library%/github.com/grpc-ecosystem/grpc-gateway/v2/runtime.a failed (Exit 1) builder failed: error executing command bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64_race -tags race -src runtime/context.go -src runtime/convert.go -src runtime/doc.go -src ... (remaining 77 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
compilepkg: error running subcommand: exit status 2
/root/.cache/_grpc_gateway_bazel/sandbox/processwrapper-sandbox/534/execroot/grpc_ecosystem_grpc_gateway/runtime/query.go:260:12: cannot assign *timestamp.Timestamp to msg (type protoreflect.ProtoMessage) in multiple assignment:
	*timestamp.Timestamp does not implement protoreflect.ProtoMessage (missing ProtoReflect method)
/root/.cache/_grpc_gateway_bazel/sandbox/processwrapper-sandbox/534/execroot/grpc_ecosystem_grpc_gateway/runtime/query.go:272:7: cannot use ptypes.DurationProto(d) (type *duration.Duration) as type protoreflect.ProtoMessage in assignment:
	*duration.Duration does not implement protoreflect.ProtoMessage (missing ProtoReflect method)
/root/.cache/_grpc_gateway_bazel/sandbox/processwrapper-sandbox/534/execroot/grpc_ecosystem_grpc_gateway/runtime/query.go:329:9: undefined: "github.com/golang/protobuf/proto".MessageV2
INFO: Elapsed time: 92.311s, Critical Path: 73.69s

Meanwhile, go build ./... works fine. It's like bazel is using the wrong version of github.com/golang/protobuf (pre-v1.4.0), but repositories.bzl seems to be up to date, so what's going on?

@drigz please help me like you have with all my other bazel issues 😂.

[johanbrandhorst]

Great, it's actually not fixed, because now we're getting this error instead:

/root/.cache/_grpc_gateway_bazel/sandbox/processwrapper-sandbox/9/execroot/grpc_ecosystem_grpc_gateway/runtime/query.go:343:9: undefined: "github.com/golang/protobuf/proto".MessageV2

I'll revert the change and go back to ptypes and just wait for the next release of rules_go.

[drigz]

Did you find https://nullset.xyz/2020/04/20/bazel-go-and-protobufs/? Does it help?

bazel-contrib/rules_go#2395 was closed a week and a half ago, so maybe using rules_go from master is easier than excising uses of the new APIv2.

[johanbrandhorst]

Did you find https://nullset.xyz/2020/04/20/bazel-go-and-protobufs/? Does it help?

bazelbuild/rules_go#2395 was closed a week and a half ago, so maybe using rules_go from master is easier than excising uses of the new APIv2.

Thanks Rodrigo, I took some time to investigate the error and landed on the same conclusion as you. I actually upgraded to rules_go from master to test it, and it does work (the bazel build is now failing for other reasons), but I'm going to back out the change again and simply wait for the next release to drop before merging this.

Thanks again for all your help 😍.