runtime: rewrite fieldmask logic with protoreflect #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
rewrite-fieldmask-protoreflect
branch
2 times, most recently
from
af65d30 to
b41cfdc
Compare
johanbrandhorst
force-pushed
the
rewrite-fieldmask-protoreflect
branch
2 times, most recently
from
59a30ab to
b25e8dc
Compare
|
Bazel is failing for the same reason as #1272, will have to wait for the next release of |
|
does it possible to with rewriting not import glog logger package to minimize deps (i'm use parts of runtime package in other project) |
Sure, would you like to submit a PR to remove this? I don't think it's relevant to this PR. |
johanbrandhorst
force-pushed
the
rewrite-fieldmask-protoreflect
branch
11 times, most recently
from
03d85a3 to
52174f2
Compare
Replace the use of the descriptorpb when we can use reflection instead. Also add more thorough test and support repeated fields.
johanbrandhorst
force-pushed
the
rewrite-fieldmask-protoreflect
branch
from
52174f2 to
c950d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of the descriptorpb when we can use reflection
instead. Also add more thorough test and support repeated fields.