-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental/credentials: Add experimental credentials that don't enforce ALPN #7980
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7980 +/- ##
==========================================
+ Coverage 82.28% 82.29% +0.01%
==========================================
Files 381 384 +3
Lines 38539 38745 +206
==========================================
+ Hits 31712 31887 +175
- Misses 5535 5559 +24
- Partials 1292 1299 +7
|
4626aff
to
1d71903
Compare
1d71903
to
78c4cbf
Compare
experimental/credentials/tls.go
Outdated
// Package credentials provides experimental TLS credentials. | ||
// The use of this package is strongly discouraged. These credentials exist | ||
// solely to maintain compatibility for users interacting with clients that | ||
// violate the HTTP/2 specification. This package is slated for removal in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe be more explicit here about the way in which they violate the spec? E.g.
...violate the HTTP/2 specification by not advertising support for "h2" in ALPN.
?
Fixes: #7922
Related Issue: #434
This change copies the existing TLS credentials, removing the code for ALPN enforcement. These credentials will be removed in a couple of releases and users who still need to disable ALPN can copy the credentials as is. Changes made:
credentials/tls.go
toexperimental/credentials/tls.go
. Add suffixWithALPNDisabled
to constructors.internal/credentials
toexperimental/credentials/internal
.RELEASE NOTES: