Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #7980 to v1.70.x #8012

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Jan 16, 2025

Original PR: #7980
Related Issues: #434, #7922

RELEASE NOTES:

  • experimental/credentials: Experimental transport credentials are added which don't enforce ALPN. These will be removed in upcoming grpc-go releases. Users must not rely on these credentials directly. Instead, they should either vendor a specific version of gRPC or copy the relevant credentials into their own codebase if absolutely necessary.

@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Jan 16, 2025
@arjan-bal arjan-bal added this to the 1.70 Release milestone Jan 16, 2025
@arjan-bal arjan-bal requested a review from purnesh42H January 16, 2025 10:17
@arjan-bal arjan-bal merged commit 54b3eb9 into grpc:v1.70.x Jan 16, 2025
12 of 13 checks passed
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 81.92771% with 30 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (62b9185) to head (f996ccf).
Report is 1 commits behind head on v1.70.x.

Files with missing lines Patch % Lines
experimental/credentials/tls.go 75.80% 26 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.70.x    #8012      +/-   ##
===========================================
+ Coverage    81.99%   82.15%   +0.16%     
===========================================
  Files          381      384       +3     
  Lines        38542    38706     +164     
===========================================
+ Hits         31602    31799     +197     
+ Misses        5616     5598      -18     
+ Partials      1324     1309      -15     
Files with missing lines Coverage Δ
credentials/tls.go 86.57% <100.00%> (ø)
experimental/credentials/internal/spiffe.go 100.00% <100.00%> (ø)
experimental/credentials/internal/syscallconn.go 100.00% <100.00%> (ø)
experimental/credentials/tls.go 75.80% <75.80%> (ø)

... and 24 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants