Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env impact yml 3362 #3428

Closed
wants to merge 2 commits into from
Closed

Update env impact yml 3362 #3428

wants to merge 2 commits into from

Conversation

RobenusW
Copy link

Fixes #replace_this_text_with_the_issue_number

What changes did you make and why did you make them ?

  • changed "content: Image" to "content-type: image"
    -deleted "type: icon"
  • we changed for clarity reasons and to get rid of redundancy

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b RobenusW-update-env-impact-yml-3362 gh-pages
git pull https://github.com/RobenusW/website.git update-env-impact-yml-3362

@Zak234 Zak234 self-requested a review July 26, 2022 08:06
@Zak234
Copy link
Contributor

Zak234 commented Jul 26, 2022

@RobenusW You need to link the issue where it says, "Fixes #replace_this_text_with_the_issue_number"

@blulady
Copy link
Member

blulady commented Jul 26, 2022

@RobenusW You need to link the issue where it says, "Fixes #replace_this_text_with_the_issue_number"

Sorry. I should have been following the contributor's guide when we were walking through this.

@Zak234
Copy link
Contributor

Zak234 commented Jul 26, 2022

ETA: July 26th
Availability: Anytime

@BeckettOBrien BeckettOBrien self-requested a review July 26, 2022 18:04
@BeckettOBrien
Copy link
Member

Availability: 5 Hours
ETA: EOD 2022-07-26

Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The I in Image is supposed to be under-case.

@blulady
Copy link
Member

blulady commented Aug 11, 2022

@RobenusW Please reach out to us if you are still working on this issue. If we don't hear back from you by August 18th, we will assume you are no longer working on it.

@ericvennemeyer ericvennemeyer self-requested a review August 17, 2022 02:26
@blulady
Copy link
Member

blulady commented Aug 18, 2022

@RobenusW Please reach out to us if you are still working on this issue. If we don't hear back from you by August 18th, we will assume you are no longer working on it.

@RobenusW today's the day, I'll give you until the end of the day and then I'll close this request.

@blulady blulady closed this Aug 19, 2022
@blulady
Copy link
Member

blulady commented Aug 19, 2022

Robenus informed me that he will be taking a break for the semester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants