Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Crystal Nucleus Tracker, Profit-Per, and Filter #2285

Merged
merged 137 commits into from
Jan 25, 2025

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Aug 1, 2024

Dependencies

What

https://discord.com/channels/997079228510117908/1194240426375401552
Adds Profit Per & Tracker for Crystal Nucleus Runs, based on the new chat messages from SB Alpha.
Adds a toggleable and configurable chat filter for the Crystal Nucleus.

Images

Per-Profit Message:
image

Tracker:
image

Chat Filters:

image

image

image

image

image

image

image

Changelog New Features

  • Added a chat filter, profit per run, and profit tracker for Crystal Nucleus runs. - Daveed

Changelog Technical Details

  • Added CrystalNucleusLootEvent for loot info upon completing a Nucleus run. - Daveed

@DavidArthurCole DavidArthurCole changed the title Feature: Crystal Nucleus Tracker & Profit-Per Feature: Crystal Nucleus Tracker, Profit-Per, and Filter Aug 2, 2024
@DavidArthurCole DavidArthurCole marked this pull request as ready for review August 2, 2024 20:32
@DavidArthurCole
Copy link
Contributor Author

This is ready for review, and could be merged as soon as that's done, however the per-profit and tracker won't function until the new Crystal Nucleus messages (in Alpha atm) make it to SB.

@DavidArthurCole
Copy link
Contributor Author

The new nuc run messages are in SB, so this is ready to go

@hannibal002 hannibal002 added this to the Version 0.27 milestone Aug 8, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Sep 7, 2024
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 24, 2025
Copy link

One or more Detekt Failures were detected:

  • CrystalNucleusAPI.kt#L94: This early return should be replaced with onlyOnIsland = IslandType in @HandleEvent annotation

Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 24, 2025
@hannibal002
Copy link
Owner

image

@hannibal002
Copy link
Owner

This pr should probably wait/depend on

@DavidArthurCole
Copy link
Contributor Author

This pr should probably wait/depend on

* [Fix + Backend: Profit Tracker rendering  #3287](https://github.com/hannibal002/SkyHanni/pull/3287)

Done, let's just hope that one gets a Soon:tm:🥺

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me

@hannibal002 hannibal002 merged commit 983df22 into hannibal002:beta Jan 25, 2025
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jan 25, 2025
@DavidArthurCole DavidArthurCole deleted the NucleusTracker branch January 25, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants