Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix + Backend: Profit Tracker rendering #3287

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Fix + Backend: Profit Tracker rendering #3287

merged 2 commits into from
Jan 24, 2025

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jan 24, 2025 •
edited
Loading

What

Fixed search in guis not working for some profit trackers by transforming all remaining trackers from gui render events to use RenderDisplayHelper.

Changelog Fixes

  • Fixed GUI search for some profit trackers. - hannibal2

Changelog Technical Details

  • All SkyHanni trackers use RenderDisplayHelper, some with initRenderer(). - hannibal2

@hannibal002 hannibal002 added Bug Fix Bug fixes Backend A backend pull request that will be merged soon labels Jan 24, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 24, 2025
@hannibal002 hannibal002 mentioned this pull request Jan 24, 2025
Merged
@DavidArthurCole DavidArthurCole mentioned this pull request Jan 24, 2025
Merged
CalMWolfs
CalMWolfs approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, didnt test

@hannibal002 hannibal002 merged commit 7d85d00 into beta Jan 24, 2025
14 of 15 checks passed
@github-actions github-actions bot removed Bug Fix Bug fixes Backend A backend pull request that will be merged soon labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hannibal002 @CalMWolfs