[feature] #2004: Forbid isize and usize from becoming IntoSchema.
#2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
appetrosyan
force-pushed
the
i2-usize-ban
branch
2 times, most recently
from
7bc1682 to
b5f83d1
Compare
appetrosyan
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI and
outoftardis
as code owners
mversic
approved these changes
May 5, 2022
mversic
reviewed
May 5, 2022
Arjentix
approved these changes
May 6, 2022
…oming `IntoSchema`. Signed-off-by: Aleksandr Petrosyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aleksandr Petrosyan [email protected]
Description of the Change
Add a unit test that fails when
usize/isizeareEncode/Decode/IntoSchemaIssue
Closes #2004
Benefits
Impossible to add structures which utilise
usize,isizeinside the schema, and thus cause UB in decoding if the pointer size on the host machine is smaller than the encoded integer.Possible Drawbacks
None
Usage Examples or Tests [optional]