Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UTF7Encoding #649

Closed
axunonb opened this issue Nov 22, 2024 · 1 comment · Fixed by #651
Closed

Remove UTF7Encoding #649

axunonb opened this issue Nov 22, 2024 · 1 comment · Fixed by #651
Labels
version 5

Comments

@axunonb
Copy link
Collaborator

axunonb commented Nov 22, 2024 •
edited
Loading

UTF7Encoding.UTF7Encoding() is obsolete:
The UTF-7 encoding is insecure and should not be used. Use UTF-8 instead.
@minichma Agree?
@minichma
Copy link
Collaborator

minichma commented Nov 24, 2024 •
edited
Loading

Aside from security, in RFC 5545 I don't see any reference to 7-bit encoding, only 8BIT and BASE64, so yes, I'd agree.

encodingparam      = "ENCODING" "="
                          ( "8BIT"
          ; "8bit" text encoding is defined in [[RFC2045](https://www.rfc-editor.org/rfc/rfc2045)]
                          / "BASE64"
          ; "BASE64" binary encoding format is defined in [[RFC4648](https://www.rfc-editor.org/rfc/rfc4648)]

axunonb added a commit to axunonb/ical.net that referenced this issue Nov 25, 2024
@axunonb
Closes ical-org#649
c22dc5a 
Remove UTF7 encoding from EncodingProvider and add unit tests

- Enabled nullable reference types.
- Added XML documentation
- Removed 7-bit methods
- Refactored 8-bit and Base64 methods to remove try-catch blocks.
- Modified Encode, DecodeString, and DecodeData to handle null values.
@axunonb axunonb mentioned this issue Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
version 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove UTF7 encoding from EncodingProvider axunonb/ical.net
2 participants
@minichma @axunonb