Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTF7 encoding from EncodingProvider #651

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

axunonb
Copy link
Collaborator

@axunonb axunonb commented Nov 25, 2024

Breaking Change
Remove UTF7 encoding from EncodingProvider and add unit tests

  • Enabled nullable reference types.
  • Added XML documentation
  • Removed 7-bit methods
  • Refactored 8-bit and Base64 methods to remove try-catch blocks.
  • Modified Encode, DecodeString, and DecodeData to handle null values.

Closes #649

Remove UTF7 encoding from EncodingProvider and add unit tests

- Enabled nullable reference types.
- Added XML documentation
- Removed 7-bit methods
- Refactored 8-bit and Base64 methods to remove try-catch blocks.
- Modified Encode, DecodeString, and DecodeData to handle null values.
@axunonb axunonb requested a review from minichma November 25, 2024 21:12
@axunonb axunonb marked this pull request as ready for review November 25, 2024 21:12
@axunonb axunonb merged commit dad1c27 into ical-org:main Nov 25, 2024
3 checks passed
@axunonb axunonb deleted the pr/remove-uitf7-encoding branch November 25, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove UTF7Encoding
2 participants