Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitswap: tried sending wantlist change to non-partner peer #4439

Closed
ghost opened this issue Nov 29, 2017 · 1 comment · Fixed by #4811
Closed

bitswap: tried sending wantlist change to non-partner peer #4439

ghost opened this issue Nov 29, 2017 · 1 comment · Fixed by #4811
Assignees
@Stebalien
Labels
kind/bug A bug in existing code (including security flaws) topic/bitswap Topic bitswap

Comments

@ghost
Copy link

ghost commented Nov 29, 2017

Version information: 0.4.13

Type: bug

Severity: medium

Description:

Seeing these a lot on the default bootstrappers.

17:21:50.682 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.682 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.682 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.683 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.683 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.683 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.684 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.684 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.685 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.686 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.686 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.686 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.687 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.690 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.690 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.690 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.691 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
17:21:50.691 WARNI    bitswap: tried sending wantlist change to non-partner peer wantmanager.go:329
@ghost ghost added topic/bitswap Topic bitswap kind/bug A bug in existing code (including security flaws) labels Nov 29, 2017
@Stebalien
Copy link
Member

We should get rid of that warning. It probably just means that we've disconnected from the peer (could even be due to the new connection closing logic).

Stebalien added a commit that referenced this issue Nov 29, 2017
@Stebalien
don't warn when trying to send wantlist to disconnected peers
048c87d 
fixes #4439

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien Stebalien mentioned this issue Nov 29, 2017
Closed
Kubuxu pushed a commit that referenced this issue Mar 12, 2018
@Stebalien @Kubuxu
don't warn when trying to send wantlist to disconnected peers
f8a7683 
fixes #4439

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien Stebalien mentioned this issue Mar 13, 2018
Merged
@ghost ghost assigned Stebalien Mar 13, 2018
@ghost ghost added the status/in-progress In progress label Mar 13, 2018
@ghost ghost removed the status/in-progress In progress label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
kind/bug A bug in existing code (including security flaws) topic/bitswap Topic bitswap
Projects
None yet
Milestone
No milestone
1 participant
@Stebalien