don't warn when trying to send wantlist to disconnected peers #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #4439 License: MIT Signed-off-by: Steven Allen <[email protected]>
|
Yeah, I think we should carefully consider what the implication here is. |
An alternative would be to reconnect but doing that may be tricky. |
|
@Stebalien I would change it to On second thought, I can change it. |
Kubuxu
added
need/author-input
|
I pushed a rebase and and a change but it is not showing up for some reason. @Stebalien I can't tag you for a review but please do. |
|
Well... there goes my attempt to close and reopen to fix it... 😞. New: #4811. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4439
@whyrusleeping while I believe this is the correct fix for this bug, it may indicate that we're not giving enough weight to bitswap peers in the connection manager.