-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC route to get note witness #3666
Add RPC route to get note witness #3666
Conversation
This is really helpful. With this pr, we can create transaction and sign a transaction locally i guess. There is one more route |
nice can you also add the documentation for this too? |
eb052fb
to
10ddd9a
Compare
@hairtail the |
I want to send transaction with a known note which called
|
@hairtail We do have some of that functionality but it is a little confusing currently. The one thing we don't have is an endpoint to create + sign a raw transaction from a list of notes + outputs which I think is what you're asking for. I think @hughy is going to pick this up in the coming weeks. We also have a endpoint that you can broadcast a signed transaction. That's in |
Summary
Adding RPC route to get the witness for a specific note index.
Testing Plan
Unit test and local testing
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Documentation: iron-fish/website#342
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.