-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chain/addTransaction for signed transaction #3716
Conversation
Guess i should tell the reason why this PR and this rpc route again. As i have said days before #3666, in my opinion and as most projects did (like btc, ethereum, filecoin etc), the |
const fourthVerify = node.wallet.memPool.acceptTransaction(transaction) | ||
if (!fourthVerify) { | ||
request.end({ success: false, reason: 'Mempool rejected' }) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acceptTransaction
could return false if the mempool already has the transaction. Should this endpoint continue even if acceptTransaction
returns false in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Mempool reject' or 'Add transaction fails' should be returned in my opinion.
907b7da
to
965753c
Compare
Hi @hairtail, this functionality will be added in #3742. Am I good to close this PR? There are a few changes to functionality:
|
Functionality will be added in another PR by the team. |
Summary
Add
chain/postTransaction
to post/broadcast an already signed transaction.Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.