Add setScanning RPC and CLI commands #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguenther
force-pushed
the
start-stop-syncing
branch
from
21e260d to
239b0f4
Compare
dguenther
changed the title
NullSoldier
force-pushed
the
start-stop-syncing
branch
from
3c8f732 to
29b54d0
Compare
* Add migration for Account.scanningEnabled * Make scanningEnabled defined
NullSoldier
reviewed
May 22, 2024
NullSoldier
reviewed
May 22, 2024
dguenther
commented
May 22, 2024
NullSoldier
reviewed
May 22, 2024
NullSoldier
reviewed
May 22, 2024
NullSoldier
reviewed
May 22, 2024
NullSoldier
reviewed
May 22, 2024
dguenther
changed the title
NullSoldier
approved these changes
May 23, 2024
dguenther
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds startScanning and stopScanning RPC routes to enable or disable wallet account scanning on a per-account basis.
TODO
Decide if chain processor should restart when starting/stopping scanningAddressing this with earliest-first scanning: Scan wallet accounts from earliest account head first #4964Fixes IFL-2547
Fixes IFL-2548
Fixes IFL-2550
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
iron-fish/website#706
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.