updated to allow for all resources not matching tag to be removed #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckuester
reviewed
May 9, 2020
|
|
||
| aws_instance: | ||
| - tags: | ||
| Persist: NOT(true) |
There was a problem hiding this comment.
In the above example all aws instances without the
Persist: truetag ... will be deleted.
Shouldn't this be "all AWS instances which tags do not match "Persist: NOT(true)" instead? Please correct me if I am wrong.
| @@ -116,6 +116,18 @@ A more detailed description of the ways to filter resources: | |||
|
|
|||
| The tag filter can be negated by surrounding the regex with `NOT(...)` | |||
|
|
|||
| Resources not matching tag can be removed with Untagged: true | |||
There was a problem hiding this comment.
In my understanding, Untagged: true means resources should be deleted that are not tagged at all :-)
See also discussion here: #91
|
Hi @sonderops Thanks for your contribution so far, I moved your commits to my feature branch (#101) and I will take care of finishing this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme outlines the change here. Currently there is no way to remove all objects NOT tagged a certain way.