Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI category to release-drafter #66

Closed
wants to merge 1 commit into from

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented Dec 8, 2020

No description provided.

@oddstr13 oddstr13 added the ci This PR updates or changes something CI related label Dec 8, 2020
@h1dden-da3m0n
Copy link
Contributor

h1dden-da3m0n commented Dec 8, 2020

Side-note: Juts in case the Jellyfin org wants to use RD more I would advice creating and using a jellyfin/.github repository where you can hold a general RD template (as well as Issue and PR templates) that you then only need to customize in the different repos that want to use it. (just FYI and feel free to give me a shout if you think I can help in any way)

@oddstr13
Copy link
Member Author

oddstr13 commented Dec 8, 2020

@h1dden-da3m0n I'd love more details on how that would work.
Would we put the files in that repo, and enable them in some way on each repo that wants to use it? (by overwriting triggers or some such?)

cc @jellyfin/core

@h1dden-da3m0n
Copy link
Contributor

h1dden-da3m0n commented Dec 8, 2020

Well, to be 100% transparent here I did mention this quite a while back in the Matrix chat. depending on that you want to do with that repo, but here the official github/.github, docu and the "example" I have the original idea from, as well as the RD information.

If you need any further info it would be my pleasure to provide it 😉

/EDIT: to answer your question more directly: GitHub files such as:

can be placed as org global default values within this .github repo and will get applied unless overwritten by the other repositories

Additionally, certain workflows (e.g. RD) can use such a repository as a configuration template repository and therefore shorten the configuration needed within each repo that wants to use them. However, RD can use any arbitrary org repo as its configuration extension point, so theoretically you could use the plugin-template repo as the source of configuration too.

Sorry for just linking the docs and my "motivation" at first.

@oddstr13
Copy link
Member Author

Right, so this is explicit support in release-drafter, not generic support for pipelines across all repos.

Would still make sense to set up release drafter template for plugins.
Maybe in the jellyfin-plugin-meta repo? Right now it's just (always out of date) list of submodules pointing to (many of) the plugin repos.

@h1dden-da3m0n
Copy link
Contributor

Unfortunately, the .github repo is only for community files such as Issue templates, Contributing guidelines etc. AFAIK (I manly knew of it due to RD and my contributions to various Jenkins plugins)
Yes the jellyfin-plugin-meta sounds like a good choice 👍 (I will open a PR tomorrow for that if that is fine)

@h1dden-da3m0n
Copy link
Contributor

h1dden-da3m0n commented Dec 15, 2020

Okay done, I hope I did not mess up 😅

/edit: I did not bother updating the sub-modules, sorry

@h1dden-da3m0n
Copy link
Contributor

btw I stumbled over this (seemingly at random xD) Sharing workflows with your organization

@oddstr13 oddstr13 requested a review from a team February 15, 2021 12:42
@oddstr13
Copy link
Member Author

oddstr13 commented Mar 9, 2021

Superseeded by jellyfin/jellyfin-meta-plugins#3 and #75

@oddstr13 oddstr13 closed this Mar 9, 2021
@oddstr13 oddstr13 deleted the pr-releasedrafter-ci-1 branch March 9, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR updates or changes something CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants