Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): centralised release-drafter #75

Merged
merged 3 commits into from
Mar 10, 2021
Merged

chore(ci): centralised release-drafter #75

merged 3 commits into from
Mar 10, 2021

Conversation

h1dden-da3m0n
Copy link
Contributor

@h1dden-da3m0n h1dden-da3m0n commented Mar 6, 2021

Description

As promised in jellyfin/jellyfin-meta-plugins#3 here a demo of how to use a centralised Release Drafter configuration.

Changes

  • allow GH workflows to run on changes in .github/**
  • simplify the dependabot config for github-actions
  • change the Release drafter config to 'extend' the centralised version

Issues

  • n/a

NOTE I am not sure if we want to keep the commit-message dependabot config for nuget packages as is, since it will always end up as fix-prefix how it stands right now

@h1dden-da3m0n
Copy link
Contributor Author

h1dden-da3m0n commented Mar 7, 2021

I should have mentioned that this should be blocked until jellyfin/jellyfin-meta-plugins#3 is merged, since otherwise the config would be invalid

@oddstr13 oddstr13 added the ci This PR updates or changes something CI related label Mar 8, 2021
@oddstr13 oddstr13 merged commit 69074e1 into jellyfin:master Mar 10, 2021
@h1dden-da3m0n
Copy link
Contributor Author

🤞 everything works as expected and thank you for the merge 🎉

@h1dden-da3m0n h1dden-da3m0n deleted the chore/centralised-drafter branch March 10, 2021 21:17
@h1dden-da3m0n
Copy link
Contributor Author

h1dden-da3m0n commented Mar 10, 2021

FIY, I will open similar PRs in the other Plugins soon ™️
Well this didn't age well 😅 thank you oddstr for propagating this across the other plugin glad u liked the idea 😁

@oddstr13
Copy link
Member

Don't worry, I only did it to the repos where I accidentally still had direct merge perms 😨 (path of least resistance), and then the one's I care the most about right now.

Plenty of plugins left to do for you too! I'm done for now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR updates or changes something CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants