fix(elb): add resource ARN to checks (prowler-cloud#2906)

jit-contrib · Oct 18, 2023 · f2415bf · f2415bf
1 parent 076517b
commit f2415bf
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 0 deletions.
diff --git a/prowler/providers/aws/services/elb/elb_insecure_ssl_ciphers/elb_insecure_ssl_ciphers.py b/prowler/providers/aws/services/elb/elb_insecure_ssl_ciphers/elb_insecure_ssl_ciphers.py
@@ -12,6 +12,7 @@ def execute(self):
             report = Check_Report_AWS(self.metadata())
             report.region = lb.region
             report.resource_id = lb.name
+            report.resource_arn = lb.arn
             report.resource_tags = lb.tags
             report.status = "PASS"
             report.status_extended = (

diff --git a/prowler/providers/aws/services/elb/elb_internet_facing/elb_internet_facing.py b/prowler/providers/aws/services/elb/elb_internet_facing/elb_internet_facing.py
@@ -9,6 +9,7 @@ def execute(self):
             report = Check_Report_AWS(self.metadata())
             report.region = lb.region
             report.resource_id = lb.name
+            report.resource_arn = lb.arn
             report.resource_tags = lb.tags
             report.status = "PASS"
             report.status_extended = f"ELB {lb.name} is not internet facing."

diff --git a/prowler/providers/aws/services/elb/elb_logging_enabled/elb_logging_enabled.py b/prowler/providers/aws/services/elb/elb_logging_enabled/elb_logging_enabled.py
@@ -9,6 +9,7 @@ def execute(self):
             report = Check_Report_AWS(self.metadata())
             report.region = lb.region
             report.resource_id = lb.name
+            report.resource_arn = lb.arn
             report.resource_tags = lb.tags
             report.status = "FAIL"
             report.status_extended = (

diff --git a/prowler/providers/aws/services/elb/elb_ssl_listeners/elb_ssl_listeners.py b/prowler/providers/aws/services/elb/elb_ssl_listeners/elb_ssl_listeners.py
@@ -10,6 +10,7 @@ def execute(self):
             report = Check_Report_AWS(self.metadata())
             report.region = lb.region
             report.resource_id = lb.name
+            report.resource_arn = lb.arn
             report.resource_tags = lb.tags
             report.status = "PASS"
             report.status_extended = f"ELB {lb.name} has HTTPS listeners only."

diff --git a/tests/providers/aws/services/elb/elb_insecure_ssl_ciphers/elb_insecure_ssl_ciphers_test.py b/tests/providers/aws/services/elb/elb_insecure_ssl_ciphers/elb_insecure_ssl_ciphers_test.py
@@ -9,6 +9,9 @@
 
 AWS_REGION = "eu-west-1"
 AWS_ACCOUNT_NUMBER = "123456789012"
+elb_arn = (
+    f"arn:aws:elasticloadbalancing:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
+)
 
 
 class Test_elb_insecure_ssl_ciphers:
@@ -115,6 +118,7 @@ def test_elb_listener_with_secure_policy(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
 
     @mock_ec2
     @mock_elb
@@ -160,3 +164,4 @@ def test_elb_with_HTTPS_listener(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
diff --git a/tests/providers/aws/services/elb/elb_internet_facing/elb_internet_facing_test.py b/tests/providers/aws/services/elb/elb_internet_facing/elb_internet_facing_test.py
@@ -9,6 +9,9 @@
 
 AWS_REGION = "eu-west-1"
 AWS_ACCOUNT_NUMBER = "123456789012"
+elb_arn = (
+    f"arn:aws:elasticloadbalancing:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
+)
 
 
 class Test_elb_request_smugling:
@@ -108,6 +111,7 @@ def test_elb_private(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
 
     @mock_ec2
     @mock_elb
@@ -153,3 +157,4 @@ def test_elb_with_deletion_protection(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
diff --git a/tests/providers/aws/services/elb/elb_logging_enabled/elb_logging_enabled_test.py b/tests/providers/aws/services/elb/elb_logging_enabled/elb_logging_enabled_test.py
@@ -9,6 +9,9 @@
 
 AWS_REGION = "eu-west-1"
 AWS_ACCOUNT_NUMBER = "123456789012"
+elb_arn = (
+    f"arn:aws:elasticloadbalancing:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
+)
 
 
 class Test_elb_logging_enabled:
@@ -108,6 +111,7 @@ def test_elb_without_access_log(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
 
     @mock_ec2
     @mock_elb
@@ -165,3 +169,4 @@ def test_elb_with_deletion_protection(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
diff --git a/tests/providers/aws/services/elb/elb_ssl_listeners/elb_ssl_listeners_test.py b/tests/providers/aws/services/elb/elb_ssl_listeners/elb_ssl_listeners_test.py
@@ -9,6 +9,9 @@
 
 AWS_REGION = "eu-west-1"
 AWS_ACCOUNT_NUMBER = "123456789012"
+elb_arn = (
+    f"arn:aws:elasticloadbalancing:{AWS_REGION}:{AWS_ACCOUNT_NUMBER}:loadbalancer/my-lb"
+)
 
 
 class Test_elb_ssl_listeners:
@@ -108,6 +111,7 @@ def test_elb_with_HTTP_listener(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn
 
     @mock_ec2
     @mock_elb
@@ -151,3 +155,4 @@ def test_elb_with_HTTPS_listener(self):
                 result[0].status_extended,
             )
             assert result[0].resource_id == "my-lb"
+            assert result[0].resource_arn == elb_arn