Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elb): add resource ARN to checks #2906

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(elb): add resource ARN to checks #2906

merged 1 commit into from
Oct 4, 2023

Conversation

MrCloudSec
Copy link
Member

Description

Add resource ARN to ELB checks.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team October 4, 2023 09:48
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2906 (7230d29) into master (4c15318) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2906   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files         540      540           
  Lines       17492    17496    +4     
=======================================
+ Hits        15087    15091    +4     
  Misses       2405     2405           
Files Coverage Δ
...b_insecure_ssl_ciphers/elb_insecure_ssl_ciphers.py 100.00% <100.00%> (ø)
...ces/elb/elb_internet_facing/elb_internet_facing.py 100.00% <100.00%> (ø)
...ces/elb/elb_logging_enabled/elb_logging_enabled.py 100.00% <100.00%> (ø)
...ervices/elb/elb_ssl_listeners/elb_ssl_listeners.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@n4ch04 n4ch04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!!

@n4ch04 n4ch04 merged commit 9793de1 into master Oct 4, 2023
@n4ch04 n4ch04 deleted the add-resource-arn-elb branch October 4, 2023 10:37
jfagoagas pushed a commit to jit-contrib/prowler that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants