Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fields hec_host and hec_port in splunk example #805

Merged
merged 3 commits into from
Aug 31, 2021
Merged

[fix] Fields hec_host and hec_port in splunk example #805

merged 3 commits into from
Aug 31, 2021

Conversation

papanito
Copy link
Contributor

@papanito papanito commented Aug 23, 2021 •
edited by pepov
Loading

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Updates the example in the Splunk docu to be correct.

Why?

The field names were wrong and not consistent with the rest of the docu

Additional context

N/A

Checklist

  • User guide and development docs updated (if needed)

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@papanito
Copy link
Contributor Author

Relates to https://github.com/banzaicloud/logging-operator-docs/pull/80

@papanito papanito mentioned this pull request Aug 23, 2021
Merged
@papanito papanito force-pushed the papanito/fix-splunk-docu branch from f644346 to bc78864 Compare August 24, 2021 04:29
@pepov pepov requested review from pepov and ahma August 24, 2021 04:34
@papanito papanito force-pushed the papanito/fix-splunk-docu branch from bc78864 to 8fca426 Compare August 27, 2021 11:56
ahma
ahma approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @papanito LGMT

@ahma ahma merged commit e76d895 into kube-logging:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@ahma ahma ahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@papanito @CLAassistant @pepov @ahma