-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] logging docu: splunk config and indentation of example code #3457
Conversation
The splunk configuration was wrong as `splunkHec` starts with lower `s`. Also fields are `hec_host` and `hec_port`.
The doc on the banzai side is autogenerated vi acode and looks like the mistake started from there. |
Let's merge this PR and keep Rancher docs accurate. |
Thanks @papanito |
Nope I guess I missed that. Will fix it... |
@catherineluse anything missing? |
@papanito Yes, if it's valid for Rancher 2.6 it should go in the 2.6 directory. |
I will create a separate PR for 2.6.x but I guess would not hurt to also update 2.5.x docu ;-) |
Merging and will use https://github.com/rancher/docs/issues/3520 for tracking of the 2.6 port |
Thanks @btat |
The splunk configuration was wrong as
splunkHec
starts with lowers
.Also fields are
hec_host
andhec_port
.When contributing to docs, please don't update the content in the v2.x folder.
It's better to update the versioned docs, for example, the v2.5 or v2.6 docs.
This content in v2.x was separated into versioned documentation during the v2.5.8
release. The content relevant to Rancher versions before v2.5 went into the v2.0-v2.4
folder, while the content related to Rancher v2.5 went into the v2.5 folder.
We are trying to get the 2.x content to be removed from Google search results. The only
reason we haven't deleted it is because Google search results would lead to 404
errors if we deleted it.