Fix: Tighten json-patch and jsonptr versions (#1700) #1701
Conversation
This fixes the conflict introduced by json-patch 3.1.0. Signed-off-by: Dan Williams <[email protected]>
danwilliams
force-pushed
the
bugfix/json-patch-version
branch
from
9859639 to
c1084d2
Compare
| @@ -58,9 +58,9 @@ hyper-rustls = { version = "0.27.1", default-features = false } | |||
| hyper-socks2 = { version = "0.9.0", default-features = false } | |||
| hyper-timeout = "0.5.1" | |||
| hyper-util = "0.1.9" | |||
| json-patch = "3" | |||
| json-patch = "3.0.1" | |||
There was a problem hiding this comment.
is this actually a tighter bound? i'm pretty sure this is ignored on the app side. you'd have to pin with ^ afaikr
There was a problem hiding this comment.
It is tighter, due to server rules - Cargo won't update it to 3.1 🙂
I first tried with pinning it, verified that this fixed the issue, and then removed the pin to just specify the minimum required version - this still works (verified locally) and it will allow patch updates but not minor version updates.
There was a problem hiding this comment.
hm, ok. well, if it works. right now CI is massively red.
There was a problem hiding this comment.
Yeah I must admit I don't have time to look into that at present - as all I've done is set the versions, and that fixes the problem locally, that should be sufficient (or useful for anyone else looking at this perhaps). If there is no other fix later then I could take a deeper look, but you may well decide to upgrade to the latest version instead of fixing to the older one 🙂
There was a problem hiding this comment.
Looking at CI logs, it seems that build is pulling in jsonptr v0.7.1 regardless of our preference. I guess if they use it, we will have to use the one they use anyway.
There was a problem hiding this comment.
In related news, 3.1.0 was yanked and 4.0.0 was released, (due to this issue) so probably will give this a day or two, then update manually.
I see they are also re-exporting jsonptr now so we can stick to pinning one dep.
danwilliams
force-pushed
the
bugfix/json-patch-version
branch
from
c1084d2 to
0f7b9ee
Compare
This fixes the conflict introduced by
json-patch3.1.0.Motivation
See #1700.
Solution
Changed
Cargo.tomlto have tighter versions, to prevent the latest version ofjson-patchbeing used, which introduces a later version ofjsonptrthan is expected.Note that the versions don't need pinning, just tightening.
Note also that they have been set to the last-known working versions, rather than the latest versions. These can be updated at leisure later, when appropriate.