Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest json-patch release has broken kube-runtime #1700

Open
danwilliams opened this issue Feb 24, 2025 · 0 comments
Open

Latest json-patch release has broken kube-runtime #1700

danwilliams opened this issue Feb 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@danwilliams
Copy link

Current and expected behavior

The json-patch crate was updated around an hour ago. It moved to v3.1.0, which now uses jsonptr v0.7.1. This breaks kube-runtime due to version numbers being quite relaxed:

In Cargo.toml of the kube project:

json-patch = "3"
jsonptr = "0.6"

The resulting cargo tree:

├── k8s-openapi v0.24.0
├── kube v0.98.0
│   ├── k8s-openapi v0.24.0 (*)
│   ├── kube-client v0.98.0
│   │   ├── k8s-openapi v0.24.0 (*)
│   │   ├── kube-core v0.98.0
│   │   │   ├── json-patch v3.1.0
│   │   │   │   ├── jsonptr v0.7.1
│   │   │   ├── k8s-openapi v0.24.0 (*)
│   ├── kube-core v0.98.0 (*)
│   ├── kube-derive v0.98.0 (proc-macro)
│   └── kube-runtime v0.98.0
│       ├── json-patch v3.1.0 (*)
│       ├── jsonptr v0.6.3
│       ├── k8s-openapi v0.24.0 (*)
│       ├── kube-client v0.98.0 (*)

Note that because the main Cargo.toml is set to version 3, it has updated to the latest json-patch, and therefore the newer jsonptr. However, elsewhere in the kube project jsonptr is used directly, and specified as 0.6.

There is an argument to make about semver in relation to json-patch, but that aside, this can be fixed trivially by tightening the version numbers in kube's Cargo.toml.

Would you like me to submit a patch? There may be a particular way you want to make the change (which is very small).

Possible solution

No response

Additional context

No response

Environment

N/A

Configuration and features

No response

Affected crates

No response

Would you like to work on fixing this bug?

None

@danwilliams danwilliams added the bug Something isn't working label Feb 24, 2025
danwilliams added a commit to danwilliams/kube that referenced this issue Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams added a commit to danwilliams/kube that referenced this issue Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams added a commit to danwilliams/kube that referenced this issue Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams added a commit to danwilliams/kube that referenced this issue Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams added a commit to danwilliams/kube that referenced this issue Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams added a commit to danwilliams/kube that referenced this issue Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.

Signed-off-by: Dan Williams <[email protected]>
sbernauer added a commit to stackabletech/trino-lb that referenced this issue Feb 24, 2025
github-merge-queue bot pushed a commit to stackabletech/trino-lb that referenced this issue Feb 24, 2025
* feat: Add simple web-based dashboard for cluster states

* changelog

* fix: Only hand queries to clusters that are able to accept queries

* fix bug

* Use askama

* clippy

* Restore Cargo.lock to work around kube-rs/kube#1700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant