-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest json-patch
release has broken kube-runtime
#1700
Labels
bug
Something isn't working
Comments
danwilliams
added a commit
to danwilliams/kube
that referenced
this issue
Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams
added a commit
to danwilliams/kube
that referenced
this issue
Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams
added a commit
to danwilliams/kube
that referenced
this issue
Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams
added a commit
to danwilliams/kube
that referenced
this issue
Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams
added a commit
to danwilliams/kube
that referenced
this issue
Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0.
danwilliams
added a commit
to danwilliams/kube
that referenced
this issue
Feb 24, 2025
This fixes the conflict introduced by json-patch 3.1.0. Signed-off-by: Dan Williams <[email protected]>
sbernauer
added a commit
to stackabletech/trino-lb
that referenced
this issue
Feb 24, 2025
github-merge-queue bot
pushed a commit
to stackabletech/trino-lb
that referenced
this issue
Feb 24, 2025
* feat: Add simple web-based dashboard for cluster states * changelog * fix: Only hand queries to clusters that are able to accept queries * fix bug * Use askama * clippy * Restore Cargo.lock to work around kube-rs/kube#1700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current and expected behavior
The
json-patch
crate was updated around an hour ago. It moved to v3.1.0, which now usesjsonptr
v0.7.1. This breakskube-runtime
due to version numbers being quite relaxed:In
Cargo.toml
of thekube
project:The resulting
cargo tree
:Note that because the main
Cargo.toml
is set to version3
, it has updated to the latestjson-patch
, and therefore the newerjsonptr
. However, elsewhere in thekube
projectjsonptr
is used directly, and specified as0.6
.There is an argument to make about semver in relation to
json-patch
, but that aside, this can be fixed trivially by tightening the version numbers inkube
'sCargo.toml
.Would you like me to submit a patch? There may be a particular way you want to make the change (which is very small).
Possible solution
No response
Additional context
No response
Environment
N/A
Configuration and features
No response
Affected crates
No response
Would you like to work on fixing this bug?
None
The text was updated successfully, but these errors were encountered: