Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test : getNetworkID method #2396

Merged
merged 1 commit into from
Oct 20, 2023
Merged

test : getNetworkID method #2396

merged 1 commit into from
Oct 20, 2023

Conversation

yorubad-dev
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

test for the important and complex logic n the getNetwork ID method, wrote unit test indepth edge cases in the program

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @KingDaemonX. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2023
@dulek
Copy link
Contributor

dulek commented Oct 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2023
dulek
dulek requested changes Oct 6, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
@yorubad-dev
Copy link
Contributor Author

yorubad-dev commented Oct 18, 2023 •
edited
Loading

@pierreprinetti can you review this
i recently made all the needed fix and want to be sure i am right on track and since @dulek isn't available currently

pierreprinetti
pierreprinetti suggested changes Oct 18, 2023
View reviewed changes
pierreprinetti
pierreprinetti approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm
/assign jichenjc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@pierreprinetti
Copy link
Member

Oh this needs a rebase unfortunately @KingDaemonX

@yorubad-dev
Copy link
Contributor Author

image

it does not have conflict or needs rebase here, so i am confuse

@pierreprinetti
Copy link
Member

image

it does not have conflict or needs rebase here, so i am confuse

Refresh perhaps? Github also shows a warning here.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
pierreprinetti
pierreprinetti approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yorubad-dev
Copy link
Contributor Author

image
it does not have conflict or needs rebase here, so i am confuse

Refresh perhaps? Github also shows a warning here.

apparently there was a new merge to the master

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@yorubad-dev
Copy link
Contributor Author

@jichenjc rebased already and ready for review

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2023
pierreprinetti
pierreprinetti reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@pierreprinetti
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@jichenjc
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
pierreprinetti
pierreprinetti approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@yorubad-dev
Copy link
Contributor Author

@pierreprinetti how do i remove the needs rebase tag
the PR is rebased and still having the label

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3c97ceb into kubernetes:master Oct 20, 2023
@pierreprinetti
Copy link
Member

@pierreprinetti how do i remove the needs rebase tag the PR is rebased and still having the label

The bot was on vacation apparently!

@yorubad-dev
Copy link
Contributor Author

@pierreprinetti how do i remove the needs rebase tag the PR is rebased and still having the label

The bot was on vacation apparently!

😅 classic

mandre pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Feb 6, 2024
@yorubad-dev @mandre
test : getNetworkID (kubernetes#2396)
2dfe9ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek dulek requested changes

@pierreprinetti pierreprinetti pierreprinetti approved these changes

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@pierreprinetti pierreprinetti

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yorubad-dev @k8s-ci-robot @dulek @pierreprinetti @jichenjc