Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test : getNetworkID method #2396

Merged
merged 1 commit into from
Oct 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 94 additions & 2 deletions pkg/openstack/loadbalancer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,6 @@ func TestLbaasV2_createLoadBalancerStatus(t *testing.T) {
result := lbaas.createLoadBalancerStatus(tt.args.service, tt.args.svcConf, tt.args.addr)
assert.Equal(t, tt.want.HostName, result.Ingress[0].Hostname)
assert.Equal(t, tt.want.IPAddress, result.Ingress[0].IP)

})
}
}
Expand Down Expand Up @@ -1632,7 +1631,6 @@ func TestLbaasV2_getMemberSubnetID(t *testing.T) {
}

func TestBuildBatchUpdateMemberOpts(t *testing.T) {

// Sample Nodes
node1 := &corev1.Node{
ObjectMeta: v1.ObjectMeta{
Expand Down Expand Up @@ -1881,3 +1879,97 @@ func Test_getSubnetID(t *testing.T) {
})
}
}

func TestLbaasV2_getNetworkID(t *testing.T) {
lbaas := LbaasV2{
LoadBalancer: LoadBalancer{
opts: LoadBalancerOpts{
LBClasses: map[string]*LBClass{
"lbclassKey": {
NetworkID: "lb-class-network-id-1234",
},
},
NetworkID: "default-lb-class-networkId",
},
},
}

type testArg struct {
service *corev1.Service
}
tests := []struct {
name string
lbaas LbaasV2
arg testArg
want string
wantErr string
}{
{
name: "get network id from service annotation",
lbaas: LbaasV2{},
arg: testArg{
service: &corev1.Service{
ObjectMeta: v1.ObjectMeta{
Annotations: map[string]string{
ServiceAnnotationLoadBalancerNetworkID: "subnet-id",
},
},
},
},
want: "subnet-id",
wantErr: "",
},
{
name: "get network id from config class",
lbaas: lbaas,
arg: testArg{
service: &corev1.Service{
ObjectMeta: v1.ObjectMeta{
Annotations: map[string]string{
ServiceAnnotationLoadBalancerClass: "lbclassKey",
},
},
},
},
want: "lb-class-network-id-1234",
wantErr: "",
},
{
name: "get network id from default config",
lbaas: lbaas,
arg: testArg{
service: &corev1.Service{},
},
want: "default-lb-class-networkId",
wantErr: "",
},
{
name: "error when loadbalancer class not found",
lbaas: LbaasV2{},
arg: testArg{
service: &corev1.Service{
ObjectMeta: v1.ObjectMeta{
Annotations: map[string]string{
ServiceAnnotationLoadBalancerClass: "invalid-lb-class",
},
},
},
},
want: "",
wantErr: "invalid loadbalancer class \"invalid-lb-class\"",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := tt.lbaas.getNetworkID(tt.arg.service, &serviceConfig{})

if tt.wantErr != "" {
assert.EqualError(t, err, tt.wantErr)
} else {
assert.NoError(t, err)
}

assert.Equal(t, tt.want, got)
})
}
}