[cinder-csi-plugin] ephemeral volume removal #2602

sergelogvinov · 2024-05-27T11:26:32Z

Disable creating new deprecated ephemeral volumes

What this PR does / why we need it:

Remove deprecated ephemeral volumes.

Which issue this PR fixes(if applicable):
fixes #2599

Special notes for reviewers:

Hi, @dulek i've disabled only ephemeral volume creation stage.
What do you think, we should remove all code or make it in two steps (releases)?

Thanks.

Release note:

In-line ephemeral is no longer available.

k8s-ci-robot · 2024-05-27T11:26:41Z

Hi @sergelogvinov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jichenjc · 2024-05-28T05:47:36Z

/ok-to-test

jichenjc · 2024-05-28T05:57:02Z

thanks for the PR, could you please update

doc needed
release notes about this PR

sergelogvinov · 2024-05-29T11:40:07Z

/retest-required

jichenjc · 2024-05-31T07:26:54Z

@sergelogvinov from the error seems more clean up needed, maybe sainty test cases?

sergelogvinov · 2024-06-04T07:26:00Z

@jichenjc All tests passed. thanks.

jichenjc · 2024-06-04T07:27:22Z

/approve

dulek · 2024-06-06T09:52:59Z

pkg/csi/cinder/nodeserver.go

-	_, err := ns.Cloud.GetVolume(volumeID)
-	if err != nil {
-		if cpoerrors.IsNotFound(err) {
-			return nil, status.Error(codes.NotFound, "Volume not found")
-		}
-		return nil, status.Errorf(codes.Internal, "GetVolume failed with error %v", err)
-	}


Why do you remove this? This doesn't exactly feel like it's related, with "csi.storage.k8s.io/ephemeral" == "true" this code won't be exected.

Hi, the main idea is - to remove openstack credentials dependency from node csi daemonset.

We do not need to check the existence of the Volume in the daemonset by openstack api. When the CSI sidecar calls the NodeStageVolume/NodePublishVolume function, the Volume is already attached to the VM. We just need to find the block device in the /dev/* directory. If any issues occur, the block device mounter will return an error.

I believe, this check _, err := ns.Cloud.GetVolume(volumeID) is not necessary here.

What do you think?

It's been a while ago when this check got in in #676. @jichenjc, do you remember why it was necessary?

@kayrus, what do you think about this?

seems last update is commit cc73e20
but didn't find the commit message realted

I am guessing this might prevent some concurrent deletion during the actions here ..

dulek · 2024-06-06T09:54:13Z

pkg/csi/cinder/nodeserver.go

-	_, err := ns.Cloud.GetVolume(volumeID)
-	if err != nil {
-		if cpoerrors.IsNotFound(err) {
-			klog.V(4).Infof("NodeUnstageVolume: Unable to find volume: %v", err)
-			return nil, status.Error(codes.NotFound, "Volume not found")
-		}
-		return nil, status.Errorf(codes.Internal, "GetVolume failed with error %v", err)
-	}


Same here, I think.

jichenjc · 2024-07-29T06:25:51Z

if no objection, let's merge this soon

sergelogvinov · 2024-07-29T09:24:41Z

i've rebased the PR... Thanks.

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2024

k8s-ci-robot requested review from dulek and zetaab May 27, 2024 11:26

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2024

sergelogvinov force-pushed the no-ephemeral branch 2 times, most recently from 1e47456 to 5f1a600 Compare May 29, 2024 11:39

sergelogvinov marked this pull request as ready for review May 29, 2024 11:39

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024

k8s-ci-robot requested a review from mdbooth May 29, 2024 11:39

sergelogvinov force-pushed the no-ephemeral branch from 5f1a600 to cce3c2c Compare June 4, 2024 05:11

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024

dulek reviewed Jun 6, 2024

View reviewed changes

sergelogvinov force-pushed the no-ephemeral branch 2 times, most recently from 5f1a600 to c714017 Compare July 29, 2024 09:23

jichenjc approved these changes Jul 29, 2024

View reviewed changes

sergelogvinov force-pushed the no-ephemeral branch from c714017 to 663ccb5 Compare July 29, 2024 14:18

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 4, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

e120335

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 4, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

5c01745

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 4, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

1912d64

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 4, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

0747317

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 11, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

bb8a24a

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 11, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

a002f62

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 12, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

654d55d

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 12, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

e3e0ba7

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 12, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

b9de18d

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 12, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

f154edb

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 18, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

d9e9d6f

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 18, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

f3ca7fd

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 20, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

8a2fa6c

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 20, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

6c66a39

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 20, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

3a6fcc0

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 26, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

71bb2ce

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 26, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

b0c4783

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 26, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

3324524

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 26, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

59d06a0

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 27, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

c779cef

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Sep 27, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

a4235ee

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 2, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

95d64db

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 2, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

0c4669c

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 2, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

41fa616

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 2, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

5d211c1

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 2, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

ca0d7bb

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 9, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

9e96127

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 11, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

d09b844

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

sergelogvinov added a commit to sergelogvinov/cloud-provider-openstack that referenced this pull request Oct 14, 2024

[cinder-csi-plugin] ephemeral volume removal (kubernetes#2602)

e28db36

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

k8s-ci-robot pushed a commit that referenced this pull request Oct 14, 2024

[cinder-csi-plugin] ephemeral volume removal (#2602) (#2640)

a294df6

Remove openstack credits from node plugin Signed-off-by: Serge Logvinov <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cinder-csi-plugin] ephemeral volume removal #2602

[cinder-csi-plugin] ephemeral volume removal #2602

sergelogvinov commented May 27, 2024 •

edited

Loading

k8s-ci-robot commented May 27, 2024

jichenjc commented May 28, 2024

jichenjc commented May 28, 2024

sergelogvinov commented May 29, 2024

jichenjc commented May 31, 2024

sergelogvinov commented Jun 4, 2024

jichenjc commented Jun 4, 2024

dulek Jun 6, 2024

sergelogvinov Jun 7, 2024

dulek Jun 7, 2024

jichenjc Jun 7, 2024

dulek Jun 6, 2024

jichenjc commented Jul 29, 2024

sergelogvinov commented Jul 29, 2024

[cinder-csi-plugin] ephemeral volume removal #2602

[cinder-csi-plugin] ephemeral volume removal #2602

Conversation

sergelogvinov commented May 27, 2024 • edited Loading

k8s-ci-robot commented May 27, 2024

jichenjc commented May 28, 2024

jichenjc commented May 28, 2024

sergelogvinov commented May 29, 2024

jichenjc commented May 31, 2024

sergelogvinov commented Jun 4, 2024

jichenjc commented Jun 4, 2024

dulek Jun 6, 2024

Choose a reason for hiding this comment

sergelogvinov Jun 7, 2024

Choose a reason for hiding this comment

dulek Jun 7, 2024

Choose a reason for hiding this comment

jichenjc Jun 7, 2024

Choose a reason for hiding this comment

dulek Jun 6, 2024

Choose a reason for hiding this comment

jichenjc commented Jul 29, 2024

sergelogvinov commented Jul 29, 2024

sergelogvinov commented May 27, 2024 •

edited

Loading