Adds openstack instance to nodeserver #676
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Build succeeded.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
| source := req.GetStagingTargetPath() | ||
| targetPath := req.GetTargetPath() | ||
| volumeCapability := req.GetVolumeCapability() | ||
|
|
||
| if len(source) == 0 || len(targetPath) == 0 || volumeCapability == nil { | ||
| if len(volumeID) == 0 || len(source) == 0 || len(targetPath) == 0 || volumeCapability == nil { |
There was a problem hiding this comment.
might be overkill, but seems like unpublish to provide detail info will help debug...
There was a problem hiding this comment.
agreed providing exactly what is missing is good for debugging, we can have a separate PR for that, as this PR addressing some other concern
This commit adds cloud instance to nodeserver and adds error codes as per csi spec.
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance |
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.15 |
ramineni
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test cloud-provider-openstack-acceptance-test-flexvolume-cinder |
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance |
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.15 |
|
Build failed.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.15 |
|
Build failed.
|
|
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.15 |
|
Build succeeded.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adisky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm thanks~ |
k8s-ci-robot
added
the
lgtm
This commit adds cloud instance to nodeserver and adds error codes as per csi spec.
This commit adds cloud instance to nodeserver to be able to query openstack and adds
error codes as per csi spec.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #661Special notes for your reviewer:
Release note: