-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annual Report for SIG Instrumentation 2024 #8327
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
bab46e3
to
cb6e882
Compare
cb6e882
to
fae58e2
Compare
|
||
[CONTRIBUTING.md]: https://git.k8s.io/community/sig-instrumentation/CONTRIBUTING.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this since we do not have a CONTRIBUTION.md for sig-instrumentation.
|
||
## [Subprojects](https://git.k8s.io/community/sig-instrumentation#subprojects) | ||
|
||
**New in 2024:** | ||
|
||
- [zpages](https://git.k8s.io/kubernetes/staging/src/k8s.io/component-base/zpages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also created #8328 to add this entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if zpages
as a feature should be put in the same category as, say, UMC or KSM? cc @dashpole @dgrisonnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually subprojects have their own repo and often have a sub-project lead. I agree this probably shouldn't be a subproject
- [x] Other contributing docs (e.g. in devel dir or contributor guide) reviewed for accuracy and updated if needed | ||
- [x] Subprojects list and linked OWNERS files in [sigs.yaml] reviewed for accuracy and updated if needed | ||
- [x] SIG leaders (chairs, tech leads, and subproject leads) in [sigs.yaml] are accurate and active, and updated if needed | ||
- [ ] Meeting notes and recordings for 2024 are linked from [README.md] and updated/uploaded if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left this unchecked since
- we didnt have the meetings recording link in the README, now added in Add sig-inst meeting recordings link #8329
- The youtube link doesnt have all the recordings from last year, need to upload those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it unchecked to document the current status. You can always upload them and then update the report 😄
I'll defer to a SIG member for the formal lgtm.
/approve (as liaison)
cc @rexagod |
[sig-governance.md]: https://git.k8s.io/community/committee-steering/governance/sig-governance.md | ||
[README.md]: https://git.k8s.io/community/sig-instrumentation/README.md | ||
[sigs.yaml]: https://git.k8s.io/community/sigs.yaml | ||
[devel]: https://git.k8s.io/community/contributors/devel/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably okay to keep this as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides uploading the recordings, LGTM! Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, pohly, rexagod, richabanker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) this PR fixes:
Fixes ##8264